[GR-51606] Introduce a typeReached check for Class.forName. #8335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
vj/GR-51606-type-reachable-for-name
branch
4 times, most recently
from
09fc585
to
1b60288
Compare
graalvmbot
force-pushed
the
vj/GR-51606-type-reachable-for-name
branch
7 times, most recently
from
604b171
to
d1352c3
Compare
graalvmbot
force-pushed
the
vj/GR-51606-type-reachable-for-name
branch
5 times, most recently
from
5219c0d
to
b323fcd
Compare
graalvmbot
force-pushed
the
vj/GR-51606-type-reachable-for-name
branch
8 times, most recently
from
c3519c8
to
b0c6869
Compare
graalvmbot
force-pushed
the
vj/GR-51606-type-reachable-for-name
branch
from
f1bea88
to
c73d231
Compare
graalvmbot
force-pushed
the
vj/GR-51606-type-reachable-for-name
branch
3 times, most recently
from
6d569be
to
3e48173
Compare
graalvmbot
force-pushed
the
vj/GR-51606-type-reachable-for-name
branch
6 times, most recently
from
d1fd7f5
to
b8f6644
Compare
The core implementation of #7480 This PR applies only for `Class.forName`. The other cases will be covered in the consecutive PRs. A type is reached if the type is initialized (successfuly, or unsuccesfully), or any of the type's subtypes are reached. Type is also reached if any of the subtypes is marked as `initialize-at-build-time`. The JSON elements `typeReached` and `typeReachable` are currently distinguished as different elements and can not be merged. This is due to the possible restriction in semantics if we merge different reflection descriptors with a condition that is different only in a runtime check. The agent still outputs `typeReachable` as the implementation is not finished for all elements. Implementation notes: * The `ClassInitializationInfo` is contains the extra field `typeReached`. * The `ClassInitializationInfo` is not a singleton for build-time initialized classes that require tracking for being reached. This is required as the field `reached` can be mutated at runtime. Review entry points: 1) For the runtime computation of reached and build-time metadata construction: substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/classinitialization/ClassInitializationInfo.java 2) For the usage of the mechanism in `Class.forName`: substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/hub/ClassForNameSupport.java 3) For parsing the JSON files: substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/configure/ConfigurationParser.java 4) For interactions with optimizations related to class initalization follow the `EnsureClassInitializedNode`: substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/classinitialization/EnsureClassInitializedNode.java.
graalvmbot
force-pushed
the
vj/GR-51606-type-reachable-for-name
branch
from
b8f6644
to
19009b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core implementation of #7480
This PR applies only for
Class.forName. The other cases will be covered in the consecutive PRs.A type is reached at run time, right before class-initialization routine starts for the a class or interface, or any of the type's subtypes are reached. Type is reached at build-time, if any of the subtypes is marked as
initialize-at-build-timeand exists in the image. Array types are not marked as reached and as such can not be used in conditions.The JSON elements
typeReachedandtypeReachableare currently distinguished as different elements and can not be merged. This is due to the possible restriction in semantics if we merge different reflection descriptors with a condition that is different only in a runtime check.The agent still outputs
typeReachableas the implementation is not finished for all elements.Implementation notes:
ClassInitializationInfocontains the extra fieldtypeReached.ClassInitializationInfois not a singleton for build-time initialized classes that require tracking for being reached. This is required as the fieldreachedcan be mutated at runtime.Review entry points:
Class.forName: substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/hub/ClassForNameSupport.javaEnsureClassInitializedNode: substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/classinitialization/EnsureClassInitializedNode.java.