Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-48956] Update -g to include all information for profiling. Fix the problem with objcopy strip command. #8516

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Mar 4, 2024

  • The objcopy strip command was effectivly doing: objcopy --strip-all --keep-symbols=<keep all> which is not correct.
  • Update -g to include all information for profiling on Linux, and now we do not need the new API option.

Results for GameOfLife example:

base           | 31   (6882776)    | 201  (7273024)    | current master
base_with_flag | 4058 (7410232)    | 4292 (7804128)    | current master + -H:-DeleteLocalSymbols
current_PR     | 29   (6882688)    | 4292 (7804072)    | after changes in this PR

Row description: name | number of symbols in symbol table for executable (size of executable in bytes) | number of symbols in symbol table for .debug (size of debug file in bytes) | comment

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 4, 2024
@graalvmbot graalvmbot force-pushed the js/GR-48956/introduce-g-perf branch from 43753c2 to 9593e0e Compare March 6, 2024 13:07
@jovanstevanovic
Copy link
Member

FYI @adinn

@graalvmbot graalvmbot force-pushed the js/GR-48956/introduce-g-perf branch from 9593e0e to bbff3d3 Compare March 7, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants