[GR-49965] [GR-51573] [GR-52422] Persist and reload analysis universe and shadow heap #8744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… types need to be persisted
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
PersistImageLayeroption, which allows to save information of theAnalysisUniverseof an image in alayer-snapshot-{image-name}.jsonfile that is stored in the artifacts path. The file format can be found at the top ofImageLayerLoader. The information currently persisted consists of theAnalysisTypes,AnalysisMethods,AnalysisFields and all theImageHeapConstants from the shadow heap.The information can then be reloaded in a subsequent image build using the option
LoadImageLayer.The type, method and field ids in the second image are the same as the first image. A part of the persisted constants are relinked, meaning they get matched to the corresponding hosted object in place of the constant that would be created in the new image. Those are the
DynamicHub, internedStringandEnumconstants. All their child constants are also persisted constants, but most of them are not backed by an hosted object. Only a predefined subset of fields are relinked as well, using the value of the hosted object of the parent constant.The field flags from the base image need to be persisted and loaded in the extension image as we will skip the analysis for most types and methods of the base image.