Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md is confusing #9

Closed
fniephaus opened this issue May 17, 2018 · 4 comments
Closed

README.md is confusing #9

fniephaus opened this issue May 17, 2018 · 4 comments
Assignees

Comments

@fniephaus
Copy link
Member

The README.md is confusing because when using GraalVM 1.0.0 RC1, you run into problems executing mx --dynamicimports /compiler build, as recommended in "With Graal". I guess what is meant is "with the Graal compiler", but the wording is confusing here. What that README is probably talking about is "using LabsJDK + Graal compiler". It would be nice to know how to run from source with the default GraalVM and to distinguish that in the README from running with the Graal compiler also built from source.

@wirthi wirthi self-assigned this May 17, 2018
@wirthi
Copy link
Member

wirthi commented May 17, 2018

Thanks for your comment, Fabio. We will clarify in the README.md that it is indeed meant when you use a Graal compiler that you built from source yourself.

Regarding using Graal.js with a GraalVM: I am not sure what you mean with that? The GraalVMs binaries we provide are shipped with Graal.js already. If you build a GraalVM yourself, the documentation for that can be found in GraalVM, not in Graal.js.

@fniephaus
Copy link
Member Author

@wirthi thanks for the swift response and for revising the README.md.

I actually meant building Graal.js with GraalVM 1.0.0 RC1. I've just checked out the repository again and tried to use GraalVM to mx --dynamicimports /compiler build Graal.js from scratch. AFAIK, the GraalVM can't compile its own compiler, but LabsJDK can.

@wirthi
Copy link
Member

wirthi commented May 17, 2018

I have updated the README a bit. For the compilation problem there is another issue open.

@wirthi wirthi closed this as completed May 17, 2018
@fniephaus
Copy link
Member Author

Thanks! Although, I think it would also be useful to mention what vm should be used for which step. mx --dynamicimports /compiler build, for example, requires LabsJDK and won't work on a GraalVM (which is not obvious for beginners).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants