-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md is confusing #9
Comments
Thanks for your comment, Fabio. We will clarify in the README.md that it is indeed meant when you use a Graal compiler that you built from source yourself. Regarding using Graal.js with a GraalVM: I am not sure what you mean with that? The GraalVMs binaries we provide are shipped with Graal.js already. If you build a GraalVM yourself, the documentation for that can be found in GraalVM, not in Graal.js. |
@wirthi thanks for the swift response and for revising the README.md. I actually meant building Graal.js with GraalVM 1.0.0 RC1. I've just checked out the repository again and tried to use GraalVM to |
I have updated the README a bit. For the compilation problem there is another issue open. |
Thanks! Although, I think it would also be useful to mention what vm should be used for which step. |
The
README.md
is confusing because when using GraalVM 1.0.0 RC1, you run into problems executingmx --dynamicimports /compiler build
, as recommended in "With Graal". I guess what is meant is "with the Graal compiler", but the wording is confusing here. What that README is probably talking about is "using LabsJDK + Graal compiler". It would be nice to know how to run from source with the default GraalVM and to distinguish that in the README from running with the Graal compiler also built from source.The text was updated successfully, but these errors were encountered: