Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for grpc-netty #148

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Add support for grpc-netty #148

merged 1 commit into from
Jan 3, 2023

Conversation

dsyer
Copy link
Contributor

@dsyer dsyer commented Dec 12, 2022

  • I have properly formatted metadata files (see CONTRIBUTING document)
  • I have added thorough tests. (see this)

@amitbansal26
Copy link

When this will be merged ?

@gradinac
Copy link
Contributor

Hey @dsyer! :) Sorry for a late answer on netty/netty#13039 (comment) - I'll continue the posts here as it's directly related to this PR.
I don't think we currently have a way to use existing metadata from other libraries in tests for a particular library. In this case, it would be best if we could use the existing metadata, but I think we can have the required netty metadata manually specified for now.
Regarding netty/netty#13039 (comment), that's a very good question. It would not make the reflection registration redundant - if a type X is reachable, we do not register anything from type X for reflection by default. In this way, we tell native-image the following: if this type does end up in the image, also register the following for it.

@gradinac gradinac self-requested a review December 29, 2022 12:40
@dsyer
Copy link
Contributor Author

dsyer commented Jan 2, 2023

So how do we get this merged? We need another approval (from whom)? Or something else?

@dnestoro dnestoro merged commit 41adcc9 into oracle:master Jan 3, 2023
@dnestoro
Copy link
Member

dnestoro commented Jan 3, 2023

@dsyer sorry for the delay, we were on holidays so we didn't merge anything these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants