Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reflection config for ConcurrentHistogram(AbstractHistogram) #238

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Feb 21, 2023

What does this PR do?

This PR adds reflection config for the ConcurrentHistogram(AbstractHistogram) constructor.

Closes gh-234

Checklist before merging

  • I have properly formatted metadata files (see CONTRIBUTING document)
  • I have added thorough tests. (see this)

Copy link
Collaborator

@bclozel bclozel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fniephaus fniephaus merged commit 3aa474e into oracle:master Feb 27, 2023
@izeye izeye deleted the gh-234 branch February 27, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants