Added more metadata for com.zaxxer:HikariCP:5.0.1 #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnestoro
reviewed
Apr 19, 2023
| @@ -171,6 +171,10 @@ | |||
| "name": "getDriverClassName", | |||
| "parameterTypes": [] | |||
| }, | |||
| { | |||
| "name": "getExceptionOverrideClassName", | |||
There was a problem hiding this comment.
Since there are no new tests provided in this PR, where do these entries come from?
There was a problem hiding this comment.
From the following change:
<logger name="com.zaxxer.hikari.HikariConfig" level="DEBUG"/>
The logConfiguration method from HikariConfig tries to load all properties using reflection and if there are no these additional metadata entries, the hikari connection pool fails in a native image.
dnestoro
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds more metadata for com.zaxxer:HikariCP:5.0.1