Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MariaDB client test #485

Closed

Conversation

mhalbritter
Copy link
Collaborator

@mhalbritter mhalbritter commented Apr 16, 2024

  • Uses an ephemeral port for docker
  • Uses 127.0.0.1 instead of localhost
  • Updates MariaDB from 10.8 to 11 (which hopefully passes the vulnerability scanners)
  • Fails fast if docker process exits early
  • print stdout and stderr if docker process exits early

@mhalbritter mhalbritter requested a review from a team as a code owner April 16, 2024 08:41
@mhalbritter mhalbritter requested a review from melix April 16, 2024 08:41
@dnestoro
Copy link
Member

This PR can't be merged since it is using vulnerable docker image

@dnestoro dnestoro closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants