Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed false error thrown if parent pom version uses variable #125

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

Achal1607
Copy link
Member

For more info apache/netbeans#7158
closes #95

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 15, 2024
arvindaprameya
arvindaprameya previously approved these changes Mar 21, 2024
Copy link
Member

@arvindaprameya arvindaprameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

lahodaj
lahodaj previously approved these changes Mar 21, 2024
Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks!

@Achal1607 Achal1607 dismissed stale reviews from lahodaj and arvindaprameya via 27a0b55 March 21, 2024 10:48
Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good.

@Achal1607 Achal1607 merged commit 32b32c9 into oracle:main Mar 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not support maven ${revision}
3 participants