Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added JDK 22 GA download option and refactored code a bit #133

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Added JDK 22 GA download option and refactored code a bit #133

merged 2 commits into from
Mar 22, 2024

Conversation

Achal1607
Copy link
Member

@Achal1607 Achal1607 commented Mar 21, 2024 •
edited

  • Added JDK 22 GA download option fr both Oracle and Oracle OpenJDK.
  • Since on every JDK release we need to update the download labels it gets problematic. So, removed specific version numbers and switched to displaying only JDK family version i.e. 21,17 or 22.
  • Also, removed version fetching from releases.json file as it was not working.

Before
image

Now
image

jdkDownloaderManagement.json is kept

{  
  oracleJdk: {
             "version":{ baseDownloaderUrl: "downloadUrl"}
  }, 
  openJdk: {
             "version":{ baseDownloaderUrl: "downloadUrl"}
  }
}

So, that in future if some more configuration for a particular JDK is wanted then we can add here without disturbing existing structure.

closes #131

@Achal1607
added JDK 22 GA download and simplified download labels
4985c93 
Signed-off-by: Achal Talati <achal.talati@oracle.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 21, 2024
arvindaprameya
arvindaprameya previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@arvindaprameya arvindaprameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thankyou

@Achal1607
replaced constant.ts with jdkDownloaderManagement.json for easier man…
6dfadc5 
…agement of downloader urls

Signed-off-by: Achal Talati <achal.talati@oracle.com>
arvindaprameya
arvindaprameya approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@arvindaprameya arvindaprameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!!

lahodaj
lahodaj approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me. Thanks!

@Achal1607 Achal1607 merged commit bef8d6e into oracle:main Mar 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvindaprameya arvindaprameya arvindaprameya approved these changes

@lahodaj lahodaj lahodaj approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JDK 22 GA download option addition in JDK Downloader
3 participants
@Achal1607 @arvindaprameya @lahodaj