Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure tests can be run and pass, on Linux #89

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

lahodaj
Copy link
Member

@lahodaj lahodaj commented Nov 30, 2023

This patch fixes a few things around running tests + adds them to the GH Actions pipeline.

Specifically:

  • ant test-vscode-ext now passes on Linux (cannot try on Mac).
  • to do that, I needed this fix: Adjusting command name for surround.with. apache/netbeans#6771 , so including it as a patch.
  • the order of application of patches is becoming important, so manual git apply * may or may not work, depending on FS order. Tried to tweak the script to use git apply + avoiding duplication of the patch names (auto-reversing the list).
  • updates to BUILD.md to reflect all this + entry in the GH workflow

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 30, 2023
Copy link
Member

@arvindaprameya arvindaprameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the necessary tests run successfully now

@sundararajana
Copy link
Member

I tested patch application as well as build/test on Mac OS. All fine.

[exec] 12 passing (37s)

...

[exec] Module Build Harness
[exec] Module Build Harness
[exec]
[exec] Unpacking org-netbeans-modules-apisupport-harness.nbm
[exec] Unpacking org-netbeans-modules-apisupport-harness.nbm
[exec]
[exec] nbcode finished with status 0
[exec] Launching NBLS with user directory: /Users/sundarajanathijegannathan/Library/Application Support/Code/User/globalStorage/Oracle.oracle-java
[exec] WARNING: A terminally deprecated method in java.lang.System has been called
[exec] WARNING: System::setSecurityManager has been called by org.netbeans.TopSecurityManager (file:/Users/sundarajanathijegannathan/src/javavscode/vscode/nbcode/platform/lib/boot.jar)
[exec] WARNING: Please consider reporting this to the maintainers of org.netbeans.TopSecurityManager
[exec] WARNING: System::setSecurityManager will be removed in a future release
[exec]
[exec] Cannot enable Ant NetBeans Module Projects[org.netbeans.modules.apisupport.ant]
[exec] - module org.netbeans.modules.ant.browsetask
[exec]
[exec]
[exec] nbcode finished with status 0

Copy link
Member

@sundararajana sundararajana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arvindaprameya arvindaprameya merged commit 4b5b13c into oracle:main Dec 1, 2023
3 checks passed
@Achal1607 Achal1607 linked an issue Dec 1, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite option "Surround with ..." is not working
3 participants