chore(deps): do not upgrade indirect Go deps #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
I still not quite get this part. By Otherwise, everything LGTM. |
tromai
approved these changes
May 9, 2023
It means that by forcefully updating the indirect dependencies, the direct dependencies that depend on them (by pinning their version) might not be compatible with the new versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209
For Go dependencies, instead of using
go get -uwe can use the code snippet suggested here to avoid updating indirect dependencies, which can result in a broken state.Note that Dependabot by default only updates the direct dependencies, so with this change
make upgrade-gowill be compatible with Dependabot.