Springboot code #162
Merged
Springboot code #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulparkinson
previously approved these changes
Aug 17, 2021
| @@ -0,0 +1,17 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
please remove this file if/as it is not necessary
| @@ -0,0 +1,4 @@ | |||
| activeProfiles= | |||
There was a problem hiding this comment.
please remove this file if/as it is not necessary
| @@ -2,7 +2,7 @@ FROM maven:3.6.3-openjdk-11 AS maven_build | |||
| COPY pom.xml /tmp/ | |||
| COPY src /tmp/src/ | |||
| WORKDIR /tmp/ | |||
| RUN mvn package | |||
| RUN mvn clean package spring-boot:repackage | |||
There was a problem hiding this comment.
please move the build out into build.sh rather than in the dockerfile (see inventory-helidon for example)
| </dependency> | ||
| <dependency> | ||
| <groupId>com.oracle.database.observability</groupId> | ||
| <artifactId>dms</artifactId> |
There was a problem hiding this comment.
I think there are some redundancies re the oracle dependencies here but we can address this when we apply 21.3 versions soon
paulparkinson
previously approved these changes
Aug 17, 2021
paulparkinson
approved these changes
Aug 18, 2021
This was referenced Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inventory- springboot