Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credentials formatting (key_passphrase => passphrase) #142

Closed
owainlewis opened this issue Mar 5, 2018 · 2 comments
Closed

Credentials formatting (key_passphrase => passphrase) #142

owainlewis opened this issue Mar 5, 2018 · 2 comments
Assignees
@owainlewis
Labels
bug documentation enhancement

Comments

@owainlewis
Copy link
Member

owainlewis commented Mar 5, 2018 •
edited

The configuration key for private key passphrase should follow normal YAML convention

key_passphrase => passphrase

https://github.com/oracle/oci-cloud-controller-manager/blob/master/pkg/oci/client/config.go#L34
@owainlewis owainlewis mentioned this issue Mar 5, 2018
Merged
@jhorwit2
Copy link
Member

jhorwit2 commented Mar 5, 2018

While we're on the subject, we should just make it passphrase which matches the other clients.

@prydie
Copy link
Contributor

prydie commented Mar 5, 2018

It's key_passphase in the flexvolume driver as well

@owainlewis owainlewis changed the title Credentials formatting (key_passphrase => keyPassphrase) Credentials formatting (key_passphrase => passphrase) Apr 4, 2018
@owainlewis owainlewis mentioned this issue Apr 5, 2018
Closed
prydie added a commit that referenced this issue Apr 6, 2018
@prydie
Depreciate auth.key_passphrase
6df4d3b 
Fixes: #142
@prydie prydie mentioned this issue Apr 6, 2018
Merged
@owainlewis owainlewis self-assigned this Apr 6, 2018
prydie added a commit that referenced this issue Apr 6, 2018
@prydie
Depreciate auth.key_passphrase
8751193 
Fixes: #142
owainlewis pushed a commit that referenced this issue Apr 6, 2018
@prydie @owainlewis
Depreciate auth.key_passphrase (#174)
848876e 
Fixes: #142
@prydie prydie mentioned this issue Apr 13, 2018
Closed
l-technicore pushed a commit to l-technicore/oci-cloud-controller-manager that referenced this issue Jun 14, 2022
@ankitkumr10
Merge pull request oracle#142 in OKE/oci-cloud-controller-manager fro…
070e73f 
…m revert/OKE-13853 to internal

* commit 'ff0a6685ee2c3381e4326aa278a5280f165e07ef':
  Revert "Update vendor dependencies for k8s v1.17"
ayushverma14 pushed a commit to ayushverma14/oci-cloud-controller-manager that referenced this issue Jul 18, 2022
@prydie @ayushverma14
Depreciate auth.key_passphrase (oracle#174)
6a3ac9b 
Fixes: oracle#142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owainlewis owainlewis

Labels
bug documentation enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@prydie @owainlewis @jhorwit2