Unify configuration format for CCM and Volume Provisioner #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the volume provisioner configuration is validated.
|
An example (reference) configuration file https://gist.github.com/owainlewis/1acff8621e5970db4cfdab89ab0f5740 |
prydie
reviewed
Nov 14, 2018
| @@ -219,7 +218,7 @@ func (cp *CloudProvider) HasClusterID() bool { | |||
| } | |||
|
|
|||
| func buildConfigurationProvider(logger *zap.Logger, config *providercfg.Config) (common.ConfigurationProvider, error) { | |||
There was a problem hiding this comment.
Are we able to do away with this as well now?
There was a problem hiding this comment.
Good spot. Thanks. Fixed.
- Fix minor typo in test framework code
ayushverma14
pushed a commit
to ayushverma14/oci-cloud-controller-manager
that referenced
this pull request
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change unifies the configuration logic between CCM and Volume Provisioner.
useInstancePrincipalsfrom top level construct.