Skip to content

Commit

Permalink
Update ODPI-C; remove error "DPI-1054: connection cannot be closed wh…
Browse files Browse the repository at this point in the history
…en open

statements or LOBs exist"
(#138).
  • Loading branch information
anthony-tuininga committed Jan 27, 2018
1 parent 5b20ca9 commit fa43311
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 13 deletions.
7 changes: 2 additions & 5 deletions doc/src/connection.rst
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,8 @@ Connection Object
connection will be unusable from this point forward; an Error exception
will be raised if any operation is attempted with the connection.

Before the connection can be closed, all cursors created by the connection
must first be closed or all references released. In addition, all LOB
objects created by the connection must have their references released. If
this has not been done, the exception "DPI-1054: connection cannot be
closed when open statements or LOBs exist" will be raised.
All open cursors and LOBs created by the connection will be closed and will
also no longer be usable.

Internally, references to the connection are held by cursor objects,
LOB objects, subscription objects, etc. Once all of these references are
Expand Down
15 changes: 8 additions & 7 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,14 @@ def run(self):
"odpi/src/dpiDeqOptions.c", "odpi/src/dpiEnqOptions.c",
"odpi/src/dpiEnv.c", "odpi/src/dpiError.c",
"odpi/src/dpiGen.c", "odpi/src/dpiGlobal.c",
"odpi/src/dpiHandlePool.c", "odpi/src/dpiLob.c",
"odpi/src/dpiMsgProps.c", "odpi/src/dpiObject.c",
"odpi/src/dpiObjectAttr.c", "odpi/src/dpiObjectType.c",
"odpi/src/dpiOci.c", "odpi/src/dpiOracleType.c",
"odpi/src/dpiPool.c", "odpi/src/dpiRowid.c",
"odpi/src/dpiStmt.c", "odpi/src/dpiSubscr.c",
"odpi/src/dpiUtils.c", "odpi/src/dpiVar.c"])
"odpi/src/dpiHandleList.c", "odpi/src/dpiHandlePool.c",
"odpi/src/dpiLob.c", "odpi/src/dpiMsgProps.c",
"odpi/src/dpiObject.c", "odpi/src/dpiObjectAttr.c",
"odpi/src/dpiObjectType.c", "odpi/src/dpiOci.c",
"odpi/src/dpiOracleType.c", "odpi/src/dpiPool.c",
"odpi/src/dpiRowid.c", "odpi/src/dpiStmt.c",
"odpi/src/dpiSubscr.c", "odpi/src/dpiUtils.c",
"odpi/src/dpiVar.c"])

# perform the setup
setup(
Expand Down
1 change: 1 addition & 0 deletions src/cx_Oracle.c
Original file line number Diff line number Diff line change
Expand Up @@ -745,6 +745,7 @@ void initcx_Oracle(void)
#include "dpiError.c"
#include "dpiGen.c"
#include "dpiGlobal.c"
#include "dpiHandleList.c"
#include "dpiHandlePool.c"
#include "dpiLob.c"
#include "dpiMsgProps.c"
Expand Down

0 comments on commit fa43311

Please sign in to comment.