Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible memory leak #298

Closed
premyslc opened this issue Apr 25, 2019 · 6 comments
Closed

Possible memory leak #298

premyslc opened this issue Apr 25, 2019 · 6 comments
Labels
bug patch available Awaiting inclusion in official release

Comments

@premyslc
Copy link

premyslc commented Apr 25, 2019 •
edited
Loading

There is probably memory leak when using nested varray and call function which return ref cursor. Problem occur only if some of nested records are NULL.

Python 3.6.7 64 bit (windows 10 64bit + linux Ubuntu 16.04 64bit)
cx_Oracle 7.1.3, 7.1.2
Oracle 12.2, 11.2

cxtest.zip
@anthony-tuininga
Copy link
Member

Thanks for the test case. I see a large amount of memory being used. I'll look into it and get back to you on the source of the issue.

anthony-tuininga added a commit to oracle/odpi that referenced this issue Apr 25, 2019
@anthony-tuininga
Eliminate memory leak when fetching objects that are null
2ea2c1d 
(oracle/python-cx_Oracle#298).
@anthony-tuininga
Copy link
Member

I discovered the source of the issue and have patched master accordingly. With the patch memory is stable.

@premyslc
Copy link
Author

Nice work. Really fast. Thanks a lot.

@anthony-tuininga
Copy link
Member

You're welcome!

anthony-tuininga added a commit to oracle/odpi that referenced this issue Apr 26, 2019
@anthony-tuininga
Only collections that are fetched should be freed; otherwise, unusual…
e0c1f03 
… OCI

errors may take place
(oracle/python-cx_Oracle#298).
@anthony-tuininga
Copy link
Member

I discovered one issue with the patch, which I have just corrected.

@anthony-tuininga anthony-tuininga added the patch available Awaiting inclusion in official release label May 3, 2019
@anthony-tuininga
Copy link
Member

This has been released with cx_Oracle 7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug patch available Awaiting inclusion in official release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@premyslc @anthony-tuininga