New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SMALLINT and FLOAT oracle db types #4

Closed
sashabaranov opened this Issue Mar 10, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@sashabaranov
Copy link

sashabaranov commented Mar 10, 2017

cx_Oracle 5.x does not handle SMALLINT and FLOAT db types. I am unsure about v6, but fix for 5.x is in #3

@anthony-tuininga

This comment has been minimized.

Copy link
Member

anthony-tuininga commented Mar 10, 2017

Thanks. Can you provide a test case that doesn't work before your patch but does afterwards? Thanks.

@sashabaranov

This comment has been minimized.

Copy link
Author

sashabaranov commented Mar 10, 2017

Sorry, I cant really reproduce this now, but basically I've experienced inability to query SMALLINT and FLOAT columns via SQLAlchemy and this fix helped.

@anthony-tuininga

This comment has been minimized.

Copy link
Member

anthony-tuininga commented Apr 5, 2017

Both 5.x and 6.x patches have now been applied.

@sashabaranov

This comment has been minimized.

Copy link
Author

sashabaranov commented Apr 17, 2017

I'm still getting error message cx_Oracle.NotSupportedError: Object_ConvertToPython(): unhandled data type 246 from branch v5.x

@anthony-tuininga

This comment has been minimized.

Copy link
Member

anthony-tuininga commented Apr 17, 2017

That seems rather strange. The test suite was updated to include smallint and float types and it passes. Please make sure that you are running the updated code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment