Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Python objects to booleans based on their Python truth value #435

Merged
merged 1 commit into from May 15, 2020
Merged

Convert Python objects to booleans based on their Python truth value #435

merged 1 commit into from May 15, 2020

Conversation

alexhenrie
Copy link
Contributor

I added tests for this, but since I don't have a local Oracle database for testing, I can't be 100% sure that they work.

@cjbj
Copy link
Member

cjbj commented May 14, 2020

Don't forget to update https://github.com/oracle/python-cx_Oracle/blob/master/doc/src/release_notes.rst !!

@alexhenrie
Copy link
Contributor Author

Don't forget to update https://github.com/oracle/python-cx_Oracle/blob/master/doc/src/release_notes.rst !!

Done.

anthony-tuininga
anthony-tuininga requested changes May 14, 2020
View reviewed changes
Copy link
Member

@anthony-tuininga anthony-tuininga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you can make those few changes I'll merge it.

doc/src/release_notes.rst Show resolved Hide resolved
test/BooleanVar.py Outdated Show resolved Hide resolved
@alexhenrie
Convert Python objects to booleans based on their Python truth value
00188b0 
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
@cjbj
Copy link
Member

cjbj commented May 15, 2020

I added tests for this, but since I don't have a local Oracle database for testing, I can't be 100% sure that they work.

Creating a DB using Oracle Cloud's free https://www.oracle.com/cloud/free/ tier can be handy for testing.

@alexhenrie
Copy link
Contributor Author

Creating a DB using Oracle Cloud's free https://www.oracle.com/cloud/free/ tier can be handy for testing.

Thanks for the suggestion! I created an Oracle Cloud account today and was able to confirm that the new tests work as they should :-)

@anthony-tuininga anthony-tuininga merged commit 17fd92f into oracle:master May 15, 2020
@anthony-tuininga
Copy link
Member

Thanks, @alexhenrie!

anthony-tuininga added a commit that referenced this pull request May 16, 2020
@anthony-tuininga
Tweaks to boolean variable improvements patch supplied by Alex Henrie
856d0aa 
(#435).
@anthony-tuininga
Copy link
Member

I made a few tweaks after examining it a bit more. Hopefully the changes are clear but if you have questions, yell out!

@alexhenrie
Copy link
Contributor Author

I made a few tweaks after examining it a bit more. Hopefully the changes are clear but if you have questions, yell out!

Looks good to me. Thanks!

@alexhenrie alexhenrie deleted the true branch August 26, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-tuininga anthony-tuininga anthony-tuininga requested changes

Assignees
No one assigned
Labels
oca-verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexhenrie @cjbj @anthony-tuininga