Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #51, #55, #59 #56

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Resolves #51, #55, #59 #56

merged 11 commits into from
Mar 13, 2024

Conversation

vadim-tropashko
Copy link
Member

  • fixed line numbers

@vadim-tropashko vadim-tropashko marked this pull request as draft February 29, 2024 00:54
@neilfernandez neilfernandez changed the title Issues 55+ Resolves #55 and #51 Mar 11, 2024
@neilfernandez neilfernandez marked this pull request as ready for review March 11, 2024 21:06
neilfernandez
neilfernandez requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@neilfernandez neilfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few changes requested, thank you Vadim

doc/user/quick-sql-grammar.md Outdated Show resolved Hide resolved
doc/user/quick-sql-grammar.md Outdated Show resolved Hide resolved
doc/user/quick-sql-grammar.md Outdated Show resolved Hide resolved
test/small_tests.js Show resolved Hide resolved
@neilfernandez neilfernandez mentioned this pull request Mar 11, 2024
Closed
@vadim-tropashko vadim-tropashko changed the title Resolves #55 and #51 Resolves #55, #51, #56 Mar 11, 2024
@vadim-tropashko vadim-tropashko changed the title Resolves #55, #51, #56 Resolves #51, #55, #59 Mar 11, 2024
neilfernandez
neilfernandez reviewed Mar 13, 2024
View reviewed changes
src/ddl.js Outdated Show resolved Hide resolved
@neilfernandez neilfernandez merged commit efff461 into main Mar 13, 2024
2 checks passed
@neilfernandez neilfernandez deleted the 2024/2/28 branch March 13, 2024 19:29
@neilfernandez neilfernandez mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilfernandez neilfernandez neilfernandez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vadim-tropashko @neilfernandez