Skip to content

Commit

Permalink
Merge pull request #1783 from oracle/release_gh
Browse files Browse the repository at this point in the history
Releasing version 4.110.0
  • Loading branch information
ravinitp committed Mar 1, 2023
2 parents 483146a + 2f08b6b commit 9134721
Show file tree
Hide file tree
Showing 131 changed files with 617 additions and 43 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
## 4.110.0 (March 01, 2023)

### Added
- adding examples for ADG and CADG, fixing is_dataguard_enabled appearing twice
### Bug Fix
- Added Resource discovery support for datascience model resource
- fix list repositories failure
- Enabling resource discovery for core - Compute Imaging CP resources

## 4.109.0 (February 22, 2023)

### Added
Expand Down
64 changes: 64 additions & 0 deletions examples/database/adb/adb_dataguard/adb_cross_region_dataguard.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
// Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved.
// Licensed under the Mozilla Public License v2.0

resource "random_string" "autonomous_database_admin_password" {
length = 16
min_numeric = 1
min_lower = 1
min_upper = 1
min_special = 1
}
resource "time_sleep" "wait_300_seconds" {
destroy_duration = "5m"
depends_on = [oci_database_autonomous_database.autonomous_database_cross_region_dataguard_primary]
}

resource "oci_database_autonomous_database" "autonomous_database_cross_region_dataguard_primary" {
admin_password = random_string.autonomous_database_admin_password.result
compartment_id = var.compartment_id
cpu_core_count = "1"
data_storage_size_in_tbs = "1"
db_name = "adbdb11ff2"
db_version = "19c"
license_model = "LICENSE_INCLUDED"
is_free_tier = "false"
}

resource "oci_database_autonomous_database" "autonomous_database_cross_region_dataguard_standby" {
#Note: this should be provisioned in another region as the source database.
provider = oci.peer_region

#Required for cross-region standby
compartment_id = var.compartment_id
source = "CROSS_REGION_DATAGUARD"
source_id = oci_database_autonomous_database.autonomous_database_cross_region_dataguard_primary.id
db_name = oci_database_autonomous_database.autonomous_database_cross_region_dataguard_primary.db_name
}

data "oci_database_autonomous_databases" "autonomous_databases" {
filter {
name = "id"
values = [oci_database_autonomous_database.autonomous_database_cross_region_dataguard_standby.id]
}

filter {
name = "peer_db_ids"
values = [oci_database_autonomous_database.autonomous_database_cross_region_dataguard_primary.id]
}

filter {
name = "role"
values = ["STANDBY"]
}

#Required
compartment_id = var.compartment_id

#Optional
display_name = oci_database_autonomous_database.autonomous_database_cross_region_dataguard_standby.display_name
}

output "autonomous_databases" {
value = data.oci_database_autonomous_databases.autonomous_databases.autonomous_databases
}

42 changes: 42 additions & 0 deletions examples/database/adb/adb_dataguard/provider.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
// Copyright (c) 2017, 2022, Oracle and/or its affiliates. All rights reserved.
// Licensed under the Mozilla Public License v2.0

variable "tenancy_ocid" {
}

variable "user_ocid" {
}

variable "fingerprint" {
}

variable "private_key_path" {
}

variable "region" {
default = "us-phoenix-1"
}

variable "peer_region" {
default = "us-ashburn-1"
}

variable "compartment_id" {
}

provider "oci" {
region = var.region
tenancy_ocid = var.tenancy_ocid
user_ocid = var.user_ocid
fingerprint = var.fingerprint
private_key_path = var.private_key_path
}

provider "oci" {
alias = "peer_region"
region = var.peer_region
tenancy_ocid = var.tenancy_ocid
user_ocid = var.user_ocid
fingerprint = var.fingerprint
private_key_path = var.private_key_path
}
Binary file modified examples/zips/adm.zip
Binary file not shown.
Binary file modified examples/zips/aiAnomalyDetection.zip
Binary file not shown.
Binary file modified examples/zips/aiVision.zip
Binary file not shown.
Binary file modified examples/zips/always_free.zip
Binary file not shown.
Binary file modified examples/zips/analytics.zip
Binary file not shown.
Binary file modified examples/zips/announcements_service.zip
Binary file not shown.
Binary file modified examples/zips/api_gateway.zip
Binary file not shown.
Binary file modified examples/zips/apm.zip
Binary file not shown.
Binary file modified examples/zips/appmgmt_control.zip
Binary file not shown.
Binary file modified examples/zips/artifacts.zip
Binary file not shown.
Binary file modified examples/zips/audit.zip
Binary file not shown.
Binary file modified examples/zips/autoscaling.zip
Binary file not shown.
Binary file modified examples/zips/bastion.zip
Binary file not shown.
Binary file modified examples/zips/big_data_service.zip
Binary file not shown.
Binary file modified examples/zips/blockchain.zip
Binary file not shown.
Binary file modified examples/zips/budget.zip
Binary file not shown.
Binary file modified examples/zips/certificatesManagement.zip
Binary file not shown.
Binary file modified examples/zips/cloudBridge.zip
Binary file not shown.
Binary file modified examples/zips/cloudMigrations.zip
Binary file not shown.
Binary file modified examples/zips/cloudguard.zip
Binary file not shown.
Binary file modified examples/zips/compute.zip
Binary file not shown.
Binary file modified examples/zips/computeinstanceagent.zip
Binary file not shown.
Binary file modified examples/zips/concepts.zip
Binary file not shown.
Binary file modified examples/zips/container_engine.zip
Binary file not shown.
Binary file modified examples/zips/container_instances.zip
Binary file not shown.
Binary file modified examples/zips/dataConnectivity.zip
Binary file not shown.
Binary file modified examples/zips/database.zip
Binary file not shown.
Binary file modified examples/zips/databaseTools.zip
Binary file not shown.
Binary file modified examples/zips/databasemanagement.zip
Binary file not shown.
Binary file modified examples/zips/databasemigration.zip
Binary file not shown.
Binary file modified examples/zips/datacatalog.zip
Binary file not shown.
Binary file modified examples/zips/dataflow.zip
Binary file not shown.
Binary file modified examples/zips/dataintegration.zip
Binary file not shown.
Binary file modified examples/zips/datalabeling.zip
Binary file not shown.
Binary file modified examples/zips/datasafe.zip
Binary file not shown.
Binary file modified examples/zips/datascience.zip
Binary file not shown.
Binary file modified examples/zips/devops.zip
Binary file not shown.
Binary file modified examples/zips/disaster_recovery.zip
Binary file not shown.
Binary file modified examples/zips/dns.zip
Binary file not shown.
Binary file modified examples/zips/em_warehouse.zip
Binary file not shown.
Binary file modified examples/zips/email.zip
Binary file not shown.
Binary file modified examples/zips/events.zip
Binary file not shown.
Binary file modified examples/zips/fast_connect.zip
Binary file not shown.
Binary file modified examples/zips/functions.zip
Binary file not shown.
Binary file modified examples/zips/fusionapps.zip
Binary file not shown.
Binary file modified examples/zips/goldengate.zip
Binary file not shown.
Binary file modified examples/zips/health_checks.zip
Binary file not shown.
Binary file modified examples/zips/id6.zip
Binary file not shown.
Binary file modified examples/zips/identity.zip
Binary file not shown.
Binary file modified examples/zips/identity_data_plane.zip
Binary file not shown.
Binary file modified examples/zips/integration.zip
Binary file not shown.
Binary file modified examples/zips/jms.zip
Binary file not shown.
Binary file modified examples/zips/kms.zip
Binary file not shown.
Binary file modified examples/zips/license_manager.zip
Binary file not shown.
Binary file modified examples/zips/limits.zip
Binary file not shown.
Binary file modified examples/zips/load_balancer.zip
Binary file not shown.
Binary file modified examples/zips/log_analytics.zip
Binary file not shown.
Binary file modified examples/zips/logging.zip
Binary file not shown.
Binary file modified examples/zips/management_agent.zip
Binary file not shown.
Binary file modified examples/zips/management_dashboard.zip
Binary file not shown.
Binary file modified examples/zips/marketplace.zip
Binary file not shown.
Binary file modified examples/zips/media_services.zip
Binary file not shown.
Binary file modified examples/zips/metering_computation.zip
Binary file not shown.
Binary file modified examples/zips/monitoring.zip
Binary file not shown.
Binary file modified examples/zips/mysql.zip
Binary file not shown.
Binary file modified examples/zips/network_firewall.zip
Binary file not shown.
Binary file modified examples/zips/network_load_balancer.zip
Binary file not shown.
Binary file modified examples/zips/networking.zip
Binary file not shown.
Binary file modified examples/zips/nosql.zip
Binary file not shown.
Binary file modified examples/zips/notifications.zip
Binary file not shown.
Binary file modified examples/zips/object_storage.zip
Binary file not shown.
Binary file modified examples/zips/ocvp.zip
Binary file not shown.
Binary file modified examples/zips/onesubscription.zip
Binary file not shown.
Binary file modified examples/zips/opa.zip
Binary file not shown.
Binary file modified examples/zips/opensearch.zip
Binary file not shown.
Binary file modified examples/zips/operator_access_control.zip
Binary file not shown.
Binary file modified examples/zips/opsi.zip
Binary file not shown.
Binary file modified examples/zips/optimizer.zip
Binary file not shown.
Binary file modified examples/zips/oracle_cloud_vmware_solution.zip
Binary file not shown.
Binary file modified examples/zips/oracle_content_experience.zip
Binary file not shown.
Binary file modified examples/zips/oracle_digital_assistant.zip
Binary file not shown.
Binary file modified examples/zips/osmanagement.zip
Binary file not shown.
Binary file modified examples/zips/osp_gateway.zip
Binary file not shown.
Binary file modified examples/zips/osub_billing_schedule.zip
Binary file not shown.
Binary file modified examples/zips/osub_organization_subscription.zip
Binary file not shown.
Binary file modified examples/zips/osub_subscription.zip
Binary file not shown.
Binary file modified examples/zips/osub_usage.zip
Binary file not shown.
Binary file modified examples/zips/pic.zip
Binary file not shown.
Binary file modified examples/zips/queue.zip
Binary file not shown.
Binary file modified examples/zips/recovery.zip
Binary file not shown.
Binary file modified examples/zips/resourcemanager.zip
Binary file not shown.
Binary file modified examples/zips/serviceManagerProxy.zip
Binary file not shown.
Binary file modified examples/zips/service_catalog.zip
Binary file not shown.
Binary file modified examples/zips/service_connector_hub.zip
Binary file not shown.
Binary file modified examples/zips/service_mesh.zip
Binary file not shown.
Binary file modified examples/zips/stack_monitoring.zip
Binary file not shown.
Binary file modified examples/zips/storage.zip
Binary file not shown.
Binary file modified examples/zips/streaming.zip
Binary file not shown.
Binary file modified examples/zips/usage_proxy.zip
Binary file not shown.
Binary file modified examples/zips/vault_secret.zip
Binary file not shown.
Binary file modified examples/zips/vbs_inst.zip
Binary file not shown.
Binary file modified examples/zips/visual_builder.zip
Binary file not shown.
Binary file modified examples/zips/vn_monitoring.zip
Binary file not shown.
Binary file modified examples/zips/vulnerability_scanning_service.zip
Binary file not shown.
Binary file modified examples/zips/web_app_acceleration.zip
Binary file not shown.
Binary file modified examples/zips/web_app_firewall.zip
Binary file not shown.
Binary file modified examples/zips/web_application_acceleration_and_security.zip
Binary file not shown.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ require (
github.com/mitchellh/mapstructure v1.1.2 // indirect
github.com/mitchellh/reflectwalk v1.0.2 // indirect
github.com/oklog/run v1.0.0 // indirect
github.com/oracle/oci-go-sdk/v65 v65.31.0
github.com/oracle/oci-go-sdk/v65 v65.31.1
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/sony/gobreaker v0.5.0 // indirect
github.com/ulikunitz/xz v0.5.8 // indirect
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,8 @@ github.com/oklog/run v1.0.0/go.mod h1:dlhp/R75TPv97u0XWUtDeV/lRKWPKSdTuV0TZvrmrQ
github.com/onsi/ginkgo v1.6.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE=
github.com/onsi/ginkgo v1.7.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE=
github.com/onsi/gomega v1.4.3/go.mod h1:ex+gbHU/CVuBBDIJjb2X0qEXbFg53c61hWP/1CpauHY=
github.com/oracle/oci-go-sdk/v65 v65.31.0 h1:lDm6L3+/30+tKYHx9RCwsYxJEZUWJ/KEOU4egTQDi+0=
github.com/oracle/oci-go-sdk/v65 v65.31.0/go.mod h1:oyMrMa1vOzzKTmPN+kqrTR9y9kPA2tU1igN3NUSNTIE=
github.com/oracle/oci-go-sdk/v65 v65.31.1 h1:GcVydzh3M4IbH4Y1XienA3W/bR02SMag0stfw9UbjtQ=
github.com/oracle/oci-go-sdk/v65 v65.31.1/go.mod h1:oyMrMa1vOzzKTmPN+kqrTR9y9kPA2tU1igN3NUSNTIE=
github.com/pierrec/lz4 v2.0.5+incompatible/go.mod h1:pdkljMzZIN41W+lC3N2tnIh5sFi+IEE17M5jbnwPHcY=
github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
Expand Down
4 changes: 2 additions & 2 deletions internal/globalvar/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import (
"log"
)

const Version = "4.108.1"
const ReleaseDate = "2023-02-21"
const Version = "4.110.0"
const ReleaseDate = "2023-03-01"

func PrintVersion() {
log.Printf("[INFO] terraform-provider-oci %s\n", Version)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (

var (
CoreCoreComputeGlobalImageCapabilitySchemaSingularDataSourceRepresentation = map[string]interface{}{

"compute_global_image_capability_schema_id": acctest.Representation{RepType: acctest.Required, Create: `${data.oci_core_compute_global_image_capability_schemas.test_compute_global_image_capability_schemas.compute_global_image_capability_schemas.0.id}`},
}

Expand All @@ -26,7 +27,9 @@ var (

// issue-routing-tag: core/computeImaging
func TestCoreComputeGlobalImageCapabilitySchemaResource_basic(t *testing.T) {

httpreplay.SetScenario("TestCoreComputeGlobalImageCapabilitySchemaResource_basic")

defer httpreplay.SaveScenario()

config := acctest.ProviderTestConfig()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@ import (

var (
CoreCoreComputeGlobalImageCapabilitySchemasVersionSingularDataSourceRepresentation = map[string]interface{}{

"compute_global_image_capability_schema_id": acctest.Representation{RepType: acctest.Required, Create: `${data.oci_core_compute_global_image_capability_schemas.test_compute_global_image_capability_schemas.compute_global_image_capability_schemas.0.id}`},
"compute_global_image_capability_schema_version_name": acctest.Representation{RepType: acctest.Required, Create: `${data.oci_core_compute_global_image_capability_schemas_versions.test_compute_global_image_capability_schemas_versions.compute_global_image_capability_schema_versions.0.name}`},
}

CoreCoreComputeGlobalImageCapabilitySchemasVersionDataSourceRepresentation = map[string]interface{}{

"compute_global_image_capability_schema_id": acctest.Representation{RepType: acctest.Required, Create: `${data.oci_core_compute_global_image_capability_schemas.test_compute_global_image_capability_schemas.compute_global_image_capability_schemas.0.id}`},
"display_name": acctest.Representation{RepType: acctest.Optional, Create: `displayName`},
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,16 @@ var (

CoreCoreComputeImageCapabilitySchemaSingularDataSourceRepresentation = map[string]interface{}{
"compute_image_capability_schema_id": acctest.Representation{RepType: acctest.Required, Create: `${oci_core_compute_image_capability_schema.test_compute_image_capability_schema.id}`},
"is_merge_enabled": acctest.Representation{RepType: acctest.Required, Create: `false`},

"is_merge_enabled": acctest.Representation{RepType: acctest.Required, Create: `false`},
}

CoreCoreComputeImageCapabilitySchemaDataSourceRepresentation = map[string]interface{}{
"compartment_id": acctest.Representation{RepType: acctest.Optional, Create: `${var.compartment_id}`},
"display_name": acctest.Representation{RepType: acctest.Optional, Create: `displayName`, Update: `displayName2`},
"image_id": acctest.Representation{RepType: acctest.Optional, Create: `${oci_core_compute_image_capability_schema.test_compute_image_capability_schema.image_id}`},
"filter": acctest.RepresentationGroup{RepType: acctest.Required, Group: CoreComputeImageCapabilitySchemaDataSourceFilterRepresentation}}

"display_name": acctest.Representation{RepType: acctest.Optional, Create: `displayName`, Update: `displayName2`},
"image_id": acctest.Representation{RepType: acctest.Optional, Create: `${oci_core_compute_image_capability_schema.test_compute_image_capability_schema.image_id}`},
"filter": acctest.RepresentationGroup{RepType: acctest.Required, Group: CoreComputeImageCapabilitySchemaDataSourceFilterRepresentation}}
CoreComputeImageCapabilitySchemaDataSourceFilterRepresentation = map[string]interface{}{
"name": acctest.Representation{RepType: acctest.Required, Create: `id`},
"values": acctest.Representation{RepType: acctest.Required, Create: []string{`${oci_core_compute_image_capability_schema.test_compute_image_capability_schema.id}`}},
Expand Down Expand Up @@ -92,6 +94,7 @@ resource "oci_core_image" "custom_image" {

// issue-routing-tag: core/computeImaging
func TestCoreComputeImageCapabilitySchemaResource_basic(t *testing.T) {

t.Skip("Skip test for Windows image")
httpreplay.SetScenario("TestCoreComputeImageCapabilitySchemaResource_basic")
defer httpreplay.SaveScenario()
Expand Down
21 changes: 14 additions & 7 deletions internal/integrationtest/datascience_model_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,14 @@ var (
}

DatascienceDatascienceModelDataSourceRepresentation = map[string]interface{}{
"compartment_id": acctest.Representation{RepType: acctest.Required, Create: `${var.compartment_id}`},
"display_name": acctest.Representation{RepType: acctest.Optional, Create: `displayName`, Update: `displayName2`},
"id": acctest.Representation{RepType: acctest.Optional, Create: `${oci_datascience_model.test_model.id}`},
"project_id": acctest.Representation{RepType: acctest.Optional, Create: `${oci_datascience_project.test_project.id}`},
"state": acctest.Representation{RepType: acctest.Optional, Create: `ACTIVE`},
"filter": acctest.RepresentationGroup{RepType: acctest.Required, Group: DatascienceModelDataSourceFilterRepresentation}}
"compartment_id": acctest.Representation{RepType: acctest.Required, Create: `${var.compartment_id}`},
"display_name": acctest.Representation{RepType: acctest.Optional, Create: `displayName`, Update: `displayName2`},
"id": acctest.Representation{RepType: acctest.Optional, Create: `${oci_datascience_model.test_model.id}`},
"model_version_set_name": acctest.Representation{RepType: acctest.Optional, Create: ``},
"project_id": acctest.Representation{RepType: acctest.Optional, Create: `${oci_datascience_project.test_project.id}`},
"state": acctest.Representation{RepType: acctest.Optional, Create: `ACTIVE`},
"version_label": acctest.Representation{RepType: acctest.Optional, Create: ``, Update: ``},
"filter": acctest.RepresentationGroup{RepType: acctest.Required, Group: DatascienceModelDataSourceFilterRepresentation}}
DatascienceModelDataSourceFilterRepresentation = map[string]interface{}{
"name": acctest.Representation{RepType: acctest.Required, Create: `id`},
"values": acctest.Representation{RepType: acctest.Required, Create: []string{`${oci_datascience_model.test_model.id}`}},
Expand Down Expand Up @@ -76,6 +78,10 @@ var (

DatascienceModelResourceDependencies = acctest.GenerateResourceFromRepresentationMap("oci_datascience_project", "test_project", acctest.Required, acctest.Create, DatascienceProjectRepresentation) +
DefinedTagsDependencies

DatascienceModelResourceModelVersionSetDependencies = acctest.GenerateResourceFromRepresentationMap("oci_datascience_model_version_set", "test_model_version_set", acctest.Required, acctest.Create, DatascienceModelVersionSetRepresentation) +
acctest.GenerateResourceFromRepresentationMap("oci_datascience_project", "test_project", acctest.Required, acctest.Create, DatascienceProjectRepresentation) +
DefinedTagsDependencies
)

// issue-routing-tag: datascience/default
Expand Down Expand Up @@ -241,11 +247,12 @@ func TestDatascienceModelResource_basic(t *testing.T) {
{
Config: config +
acctest.GenerateDataSourceFromRepresentationMap("oci_datascience_models", "test_models", acctest.Optional, acctest.Update, DatascienceDatascienceModelDataSourceRepresentation) +
compartmentIdVariableStr + DatascienceModelResourceDependencies +
compartmentIdVariableStr + DatascienceModelResourceModelVersionSetDependencies +
acctest.GenerateResourceFromRepresentationMap("oci_datascience_model", "test_model", acctest.Optional, acctest.Update, DatascienceModelRepresentation),
Check: acctest.ComposeAggregateTestCheckFuncWrapper(
resource.TestCheckResourceAttr(datasourceName, "compartment_id", compartmentId),
resource.TestCheckResourceAttr(datasourceName, "display_name", "displayName2"),
resource.TestCheckResourceAttrSet(datasourceName, "id"),
resource.TestCheckResourceAttrSet(datasourceName, "project_id"),
resource.TestCheckResourceAttr(datasourceName, "state", "ACTIVE"),

Expand Down
18 changes: 7 additions & 11 deletions internal/integrationtest/devops_repository_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ var (
}

DevopsRepositoryResourceDependencies = acctest.GenerateResourceFromRepresentationMap("oci_devops_project", "test_project", acctest.Required, acctest.Create, DevopsProjectRepresentation) +
acctest.GenerateResourceFromRepresentationMap("oci_devops_connection", "test_connection", acctest.Required, acctest.Create, DevopsConnectionRepresentation) +
DefinedTagsDependencies +
acctest.GenerateResourceFromRepresentationMap("oci_ons_notification_topic", "test_notification_topic", acctest.Required, acctest.Create, OnsNotificationTopicRepresentation)
)
Expand All @@ -72,22 +71,19 @@ func TestDevopsRepositoryResource_basic(t *testing.T) {
compartmentId := utils.GetEnvSettingWithBlankDefault("compartment_ocid")
compartmentIdVariableStr := fmt.Sprintf("variable \"compartment_id\" { default = \"%s\" }\n", compartmentId)

githubAccessTokenVaultId := utils.GetEnvSettingWithBlankDefault("github_access_token_vault_id")
githubAccessTokenVaultIdStr := fmt.Sprintf("variable \"github_access_token_vault_id\" { default = \"%s\" }\n", githubAccessTokenVaultId)

resourceName := "oci_devops_repository.test_repository"
datasourceName := "data.oci_devops_repositories.test_repositories"
singularDatasourceName := "data.oci_devops_repository.test_repository"

var resId, resId2 string
// Save TF content to Create resource with optional properties. This has to be exactly the same as the config part in the "create with optionals" step in the test.
acctest.SaveConfigContent(config+compartmentIdVariableStr+githubAccessTokenVaultIdStr+DevopsRepositoryResourceDependencies+
acctest.SaveConfigContent(config+compartmentIdVariableStr+DevopsRepositoryResourceDependencies+
acctest.GenerateResourceFromRepresentationMap("oci_devops_repository", "test_repository", acctest.Optional, acctest.Create, DevopsRepositoryRepresentation), "devops", "repository", t)

acctest.ResourceTest(t, testAccCheckDevopsRepositoryDestroy, []resource.TestStep{
// verify Create
{
Config: config + compartmentIdVariableStr + githubAccessTokenVaultIdStr + DevopsRepositoryResourceDependencies +
Config: config + compartmentIdVariableStr + DevopsRepositoryResourceDependencies +
acctest.GenerateResourceFromRepresentationMap("oci_devops_repository", "test_repository", acctest.Required, acctest.Create, DevopsRepositoryRepresentation),
Check: acctest.ComposeAggregateTestCheckFuncWrapper(
resource.TestCheckResourceAttr(resourceName, "name", "name"),
Expand All @@ -103,11 +99,11 @@ func TestDevopsRepositoryResource_basic(t *testing.T) {

// delete before next Create
{
Config: config + compartmentIdVariableStr + githubAccessTokenVaultIdStr + DevopsRepositoryResourceDependencies,
Config: config + compartmentIdVariableStr + DevopsRepositoryResourceDependencies,
},
//verify Create with optionals
{
Config: config + compartmentIdVariableStr + githubAccessTokenVaultIdStr + DevopsRepositoryResourceDependencies +
Config: config + compartmentIdVariableStr + DevopsRepositoryResourceDependencies +
acctest.GenerateResourceFromRepresentationMap("oci_devops_repository", "test_repository", acctest.Optional, acctest.Create, DevopsRepositoryRepresentation),
Check: acctest.ComposeAggregateTestCheckFuncWrapper(
resource.TestCheckResourceAttrSet(resourceName, "compartment_id"),
Expand All @@ -133,7 +129,7 @@ func TestDevopsRepositoryResource_basic(t *testing.T) {

// verify updates to updatable parameters
{
Config: config + compartmentIdVariableStr + githubAccessTokenVaultIdStr + DevopsRepositoryResourceDependencies +
Config: config + compartmentIdVariableStr + DevopsRepositoryResourceDependencies +
acctest.GenerateResourceFromRepresentationMap("oci_devops_repository", "test_repository", acctest.Optional, acctest.Update, DevopsRepositoryRepresentation),
Check: acctest.ComposeAggregateTestCheckFuncWrapper(
resource.TestCheckResourceAttrSet(resourceName, "compartment_id"),
Expand All @@ -158,7 +154,7 @@ func TestDevopsRepositoryResource_basic(t *testing.T) {
{
Config: config +
acctest.GenerateDataSourceFromRepresentationMap("oci_devops_repositories", "test_repositories", acctest.Optional, acctest.Update, DevopsDevopsRepositoryDataSourceRepresentation) +
compartmentIdVariableStr + githubAccessTokenVaultIdStr + DevopsRepositoryResourceDependencies +
compartmentIdVariableStr + DevopsRepositoryResourceDependencies +
acctest.GenerateResourceFromRepresentationMap("oci_devops_repository", "test_repository", acctest.Optional, acctest.Update, DevopsRepositoryRepresentation),
Check: acctest.ComposeAggregateTestCheckFuncWrapper(
resource.TestCheckResourceAttr(datasourceName, "repository_collection.#", "1"),
Expand All @@ -169,7 +165,7 @@ func TestDevopsRepositoryResource_basic(t *testing.T) {
{
Config: config +
acctest.GenerateDataSourceFromRepresentationMap("oci_devops_repository", "test_repository", acctest.Required, acctest.Create, DevopsDevopsRepositorySingularDataSourceRepresentation) +
compartmentIdVariableStr + githubAccessTokenVaultIdStr + DevopsRepositoryResourceConfig,
compartmentIdVariableStr + DevopsRepositoryResourceConfig,
Check: acctest.ComposeAggregateTestCheckFuncWrapper(
resource.TestCheckResourceAttrSet(singularDatasourceName, "repository_id"),
resource.TestCheckResourceAttrSet(singularDatasourceName, "branch_count"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ func (s *CoreComputeImageCapabilitySchemasDataSourceCrud) SetData() error {
computeImageCapabilitySchema["image_id"] = *r.ImageId
}

computeImageCapabilitySchema["schema_data"] = r.SchemaData
computeImageCapabilitySchema["schema_data"] = schemaDataToMap(r.SchemaData)

if r.TimeCreated != nil {
computeImageCapabilitySchema["time_created"] = r.TimeCreated.String()
Expand Down
12 changes: 12 additions & 0 deletions internal/service/datascience/datascience_export.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,17 @@ var exportDatascienceJobRunHints = &tf_export.TerraformResourceHints{
},
}

var exportDatascienceModelVersionSetHints = &tf_export.TerraformResourceHints{
ResourceClass: "oci_datascience_model_version_set",
DatasourceClass: "oci_datascience_model_version_sets",
DatasourceItemsAttr: "model_version_sets",
ResourceAbbreviation: "model_version_set",
RequireResourceRefresh: true,
DiscoverableLifecycleStates: []string{
string(oci_datascience.ModelVersionSetLifecycleStateActive),
},
}

var exportDatasciencePipelineRunHints = &tf_export.TerraformResourceHints{
ResourceClass: "oci_datascience_pipeline_run",
DatasourceClass: "oci_datascience_pipeline_runs",
Expand Down Expand Up @@ -126,6 +137,7 @@ var datascienceResourceGraph = tf_export.TerraformResourceGraph{
{TerraformResourceHints: exportDatascienceJobHints},
{TerraformResourceHints: exportDatascienceJobRunHints},
{TerraformResourceHints: exportDatasciencePipelineRunHints},
{TerraformResourceHints: exportDatascienceModelVersionSetHints},
{TerraformResourceHints: exportDatasciencePipelineHints},
},
"oci_datascience_model": {
Expand Down
Loading

0 comments on commit 9134721

Please sign in to comment.