Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing resource from state if it has been terminated so that it is recreated on next apply #257

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Removing resource from state if it has been terminated so that it is recreated on next apply #257

merged 1 commit into from
Sep 21, 2017

Conversation

rcohenma
Copy link
Contributor

…recreated on next apply

@briangustafson
Copy link
Member

Is there a specific bug that this is fixing? Can we write a test case for it?

@rcohenma
Copy link
Contributor Author

This is to fix issue #113
not sure if it is possible to write a test like this. The case is an instance is created with a terraform plan, the instance then dies or is terminated using the UI.
This fix will make it so that the next apply would recreate the instance, rather than just refreshing the state to TERMINATED in the statefile.

@rcohenma rcohenma merged commit c82cb9d into master Sep 21, 2017
@codycushing codycushing deleted the refreshTerminated branch September 29, 2017 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangustafson briangustafson briangustafson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rcohenma @briangustafson