Adds ONNX export support to the sparse linear models #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't contruct multidimensional regression infos.
JackSullivan
reviewed
Sep 7, 2021
JackSullivan
reviewed
Sep 7, 2021
Regression/SLM/src/main/java/org/tribuo/regression/slm/SparseLinearModel.java
Show resolved
Hide resolved
JackSullivan
reviewed
Sep 7, 2021
Regression/SLM/src/main/java/org/tribuo/regression/slm/SparseLinearModel.java
Show resolved
Hide resolved
JackSullivan
requested changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ONNX export support to
SparseLinearModel, which coversSLMTrainer,LARSTrainer,LARSLassoTrainerandElasticNetCDTrainer. Added a helper method toONNXUtilswhich can convert adouble[]into a float Tensor vector (unfortunately due to the packaging I can't add aDenseVectorhelper because it's not visible from tribuo-core).Also added a check to the ONNX export tests to turn off the ORT bit on arm64 platforms as ORT doesn't have an arm64 binary in the published jar on Maven Central. The tests do pass on arm64 when ORT is compiled on arm64, so if MS add the binary to Maven Central we can remove this restriction.
Finally it also fixes a bug in
RegressionFactory.constructInfoForExternalModelwhich previously couldn't construct infos for multidimensional regressions. This is copied across from the larger regression id fixes, so we'll backport that changeset to 4.1 rather than try to extract it from this one.Motivation
Expanding the set of ONNX exportable models.