Make the ONNX export code accept an op interface rather than the enum itself #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low users to supply custom ops or different opsets.
oracle-contributor-agreement
bot
added
the
OCA Verified
Util/ONNXExport/src/main/java/org/tribuo/util/onnx/ONNXOperator.java
Outdated
Show resolved
Hide resolved
Util/ONNXExport/src/main/java/org/tribuo/util/onnx/ONNXOperator.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the
ONNXOperatorinterface to allow users to insert custom ONNX ops, or ones using different opsets than opset 13 which is the base version Tribuo supports. The existingONNXOperatorsenum now implementsONNXOperator, and in a future version of Tribuo we'll rename this toONNXOpset13and split out the ONNX ML operators to a separate enum.Motivation
Currently Tribuo is limited to the ops available in
ONNXOperators, this makes the ONNX model construction code insufficiently flexible.