Adds a getter which returns a copy of the inner model #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allow users to get a copy of the internal trained models.
Closed
jhalexand
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LibLinear, LibSVM and XGBoost all have internal model representations which Tribuo hides. This PR adds an accessor which returns a deep copy of the trained models allowing users to use them outside of Tribuo.
Motivation
LibSVMModel has exposed the internal models for a while, this change makes it return an unmodifiable copy of the internal models (as the svm_model class is mutable for some reason). It then adds similar methods to LibLinearModel and XGBoostModel as it seems unfair to not allow it everywhere. We could further allow people to load in externally trained LibSVM and LibLinear models, and easily test it using this support, but it's not clear if there is need for such support at the moment.
Fixes #78.