-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rb_io_wait
is declared but not implemented
#2564
Comments
@aardvark179 is working on implementing The current conflict is unfortunate but expected: we import headers from CRuby, changed as little as possible to keep it maintainable. |
OK, so the next release will implement The polyfill in ruby-pg is here, just in case it's interesting. But sure, a complete implementation needs proper integration into |
Maybe a simple workaround here is to do some renames/prefix for the polyfill? (We're also working on the Fiber scheduler, not merged yet) |
…ffleruby-head on its road to ruby-3.0 compatibility This rename was suggested here: oracle/truffleruby#2564 (comment) It still fails in the specs, since truffleruby-head claims to be ruby-3.0 but doesn't implement Fiber.scheduler so far.
OK, I prefixed the function and enums in commit ged/ruby-pg@ec09240 so that the build and all non-scheduler tests succeed. |
|
Truffleruby on the master branch declares
rb_io_wait
but doesn't implement it. It also definesRUBY_IO_READABLE
without using it.This issue leads to a build error in ruby-pg here. The
extconf.rb
tests forrb_io_wait
and doesn't detect it, so that it enables a polyfill instead. This polyfill usually works on truffleruby, but conflicts on the definition of the function and the enum.Truffleruby-head is currently disabled in ruby-pg, but the latest truffleruby release runs successfully.
The text was updated successfully, but these errors were encountered: