-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnsureNode SourceSection does not cover the full try part, and not the ensure part #2758
Comments
def foo
begin
body1
body2
ensure
guaranteed1
guaranteed2
end
end
Truffle::Debug.print_source_sections(method(:foo)) gives
|
graalvmbot
pushed a commit
that referenced
this issue
Oct 10, 2022
…e translator * So other nodes can rely on child sections being correct while in the parser. * Fix the section of EnsureParseNode. * Fixes #2758 * Replace setPosition() by extendPosition(). * Ensure every ParseNode has a position except NilImplicitParseNode and RequiredKeywordArgumentValueParseNode .
Fix in #2761 |
graalvmbot
pushed a commit
that referenced
this issue
Oct 11, 2022
…ource section for ensure (#2758) PullRequest: truffleruby/3512
john-heinnickel
pushed a commit
to thermofisher-jch/truffleruby
that referenced
this issue
Aug 16, 2023
…e translator * So other nodes can rely on child sections being correct while in the parser. * Fix the section of EnsureParseNode. * Fixes oracle#2758 * Replace setPosition() by extendPosition(). * Ensure every ParseNode has a position except NilImplicitParseNode and RequiredKeywordArgumentValueParseNode .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Instead it seems to only cover the first line.
Debugged with @nirvdrum, the EnsureNode SourceSection only covers line 8, while the tryPart is a SequenceNode covering lines 8 and 9. The zsuper is at line 9 and can't have a breakpoint, most likely due to this.
The text was updated successfully, but these errors were encountered: