Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The buffer encoding should remain unchanged after read_nonblock(N, buffer) #3506

Closed
eregon opened this issue Mar 25, 2024 · 1 comment
Closed

The buffer encoding should remain unchanged after read_nonblock(N, buffer) #3506

eregon opened this issue Mar 25, 2024 · 1 comment
Assignees
@andrykonchin
Labels
compatibility
Milestone
24.1.0 Release (S...

Comments

@eregon
Copy link
Member

eregon commented Mar 25, 2024 •
edited

See ruby/spec#1145
Reported by @byroot
@andrykonchin andrykonchin self-assigned this Mar 26, 2024
@andrykonchin
Copy link
Member

Fixed in b4fe248

eregon added a commit to eregon/redis-client that referenced this issue Apr 11, 2024
@eregon
Improve condition for whether force_encoding is needed
5d08297 
* oracle/truffleruby#3506 was fixed,
  instead of hardcoding Ruby engines and versions, it seems better
  to do the check whether the force_encoding is needed.
@eregon eregon mentioned this issue Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrykonchin andrykonchin

Labels
compatibility
Projects
None yet
Milestone
24.1.0 Release (Sep 17, 2024)
Development

No branches or pull requests
2 participants
@eregon @andrykonchin