Implement Pattern Matching in TruffleRuby (GSoC) #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello razetime, thanks for contributing a PR to our project! We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address raghuallthetime -(at)- hotmail -(dot)- com. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
eregon
changed the title
oracle-contributor-agreement
bot
added
the
OCA Verified
razetime
force-pushed
the
gsoc-staging
branch
from
781354b
to
a9e44e1
Compare
eregon
reviewed
Nov 18, 2022
src/main/java/org/truffleruby/parser/PatternMatchingTranslator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/truffleruby/parser/PatternMatchingTranslator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/truffleruby/parser/PatternMatchingTranslator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/truffleruby/parser/PatternMatchingTranslator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/truffleruby/parser/PatternMatchingTranslator.java
Outdated
Show resolved
Hide resolved
eregon
changed the title
eregon
reviewed
Nov 21, 2022
src/main/java/org/truffleruby/language/control/CheckIfPatternsMatchedNode.java
Outdated
Show resolved
Hide resolved
eregon
reviewed
Nov 22, 2022
src/main/java/org/truffleruby/language/control/CheckIfPatternsMatchedNode.java
Outdated
Show resolved
Hide resolved
src/main/java/org/truffleruby/language/control/CheckIfPatternsMatchedNode.java
Outdated
Show resolved
Hide resolved
add related constants to RopeConstants
eregon
force-pushed
the
gsoc-staging
branch
2 times, most recently
from
d017f26
to
15143fd
Compare
eregon
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
It took a very long time for me to review and integrate this, I am sorry.
OTOH we already reviewed the code during the GSoC so the PR was in a pretty good state already.
Mostly I git filter-repo'd away the big files that were temporarily committed to avoid increasing the repo size, and I did a bunch of cleanups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done for the Ruby GSoC program in 2022, aiming to complete pattern matching tasks in #2453.
Proposal name: Implementing Ruby 3.0 Pattern Matching in TruffleRuby