Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Add Thread.each_caller_location #3050

Conversation

itarato
Copy link
Collaborator

@itarato itarato commented May 16, 2023

Source: #3039

Thread.each_caller_location is added. [Feature #16663]


Related spec updates: ruby/spec#1045

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 16, 2023
@itarato itarato self-assigned this May 16, 2023
@itarato itarato force-pushed the feature/PA-3039-Thread-each_caller_location branch from 2466fbe to d8a8b47 Compare May 16, 2023 20:27
@itarato itarato changed the title [WIP] [Compatibility] Add Thread.each_caller_location [Compatibility] Add Thread.each_caller_location May 16, 2023
@itarato itarato force-pushed the feature/PA-3039-Thread-each_caller_location branch 2 times, most recently from 0828bee to 0238230 Compare May 17, 2023 13:17
@itarato itarato changed the title [Compatibility] Add Thread.each_caller_location [WIP] [Compatibility] Add Thread.each_caller_location May 17, 2023
@itarato itarato force-pushed the feature/PA-3039-Thread-each_caller_location branch 3 times, most recently from 84e27a2 to 3004aeb Compare May 23, 2023 17:59
@itarato itarato force-pushed the feature/PA-3039-Thread-each_caller_location branch from 3004aeb to 876201a Compare May 24, 2023 17:55
@itarato itarato marked this pull request as ready for review May 24, 2023 19:20
@itarato itarato changed the title [WIP] [Compatibility] Add Thread.each_caller_location [Compatibility] Add Thread.each_caller_location May 24, 2023
@itarato itarato force-pushed the feature/PA-3039-Thread-each_caller_location branch from 876201a to c477b04 Compare June 13, 2023 18:27
CHANGELOG.md Outdated Show resolved Hide resolved
spec/ruby/core/thread/each_caller_location_spec.rb Outdated Show resolved Hide resolved
spec/ruby/core/thread/each_caller_location_spec.rb Outdated Show resolved Hide resolved
src/main/ruby/truffleruby/core/thread.rb Outdated Show resolved Hide resolved
src/main/java/org/truffleruby/core/thread/ThreadNodes.java Outdated Show resolved Hide resolved
src/main/java/org/truffleruby/core/thread/ThreadNodes.java Outdated Show resolved Hide resolved
src/main/java/org/truffleruby/core/thread/ThreadNodes.java Outdated Show resolved Hide resolved
@itarato itarato force-pushed the feature/PA-3039-Thread-each_caller_location branch from c477b04 to 2725213 Compare June 17, 2023 16:18
private static final Object STOP_ITERATE = new Object();

// Skip the block of `Thread#each_caller_location` + its internal iteration.
private static final int SKIP = 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@itarato itarato force-pushed the feature/PA-3039-Thread-each_caller_location branch from aea2758 to 55c2823 Compare June 26, 2023 12:24
@itarato itarato force-pushed the feature/PA-3039-Thread-each_caller_location branch from 55c2823 to 5e2b2c6 Compare July 15, 2023 10:38
@andrykonchin andrykonchin self-assigned this Jul 27, 2023
@andrykonchin andrykonchin added the in-ci The PR is being tested in CI. Do not push new commits. label Jul 27, 2023
@itarato itarato force-pushed the feature/PA-3039-Thread-each_caller_location branch from 5e2b2c6 to fb0b7a4 Compare July 29, 2023 21:52
@andrykonchin
Copy link
Member

Merged in #3191

@eregon eregon closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-ci The PR is being tested in CI. Do not push new commits. OCA Verified All contributors have signed the Oracle Contributor Agreement. shopify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants