Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lambda keyword argument to Proc#parameters #3429

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Add lambda keyword argument to Proc#parameters #3429

merged 1 commit into from
Feb 12, 2024

Conversation

thomasmarshall
Copy link
Contributor

Part of #3039.

This adds the lambda keyword argument to Proc#parameters as per https://bugs.ruby-lang.org/issues/15357.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 1, 2024
@thomasmarshall thomasmarshall force-pushed the proc-parameters-lambda branch 2 times, most recently from 9e9dc64 to 9f7e7c5 Compare February 1, 2024 18:51
@thomasmarshall thomasmarshall marked this pull request as ready for review February 1, 2024 19:39
andrykonchin
andrykonchin reviewed Feb 2, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@thomasmarshall thomasmarshall force-pushed the proc-parameters-lambda branch 2 times, most recently from 0c426d5 to 220bee1 Compare February 2, 2024 15:54
@thomasmarshall thomasmarshall force-pushed the proc-parameters-lambda branch 2 times, most recently from e121434 to 0459dde Compare February 2, 2024 16:34
@andrykonchin andrykonchin added the in-ci The PR is being tested in CI. Do not push new commits. label Feb 2, 2024
@thomasmarshall @goyox86
Add lambda keyword argument to Proc#parameters
dddc276 
Co-authored-by: Jose Narvaez <jose.narvaez@shopify.com>
@thomasmarshall
Copy link
Contributor Author

thomasmarshall commented Feb 2, 2024 •
edited

@andrykonchin I forced pushed to bring back the @TruffleBoundary annotation that we accidentally removed, hopefully that should get the build native job green again.

@eregon eregon merged commit dddc276 into oracle:master Feb 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrykonchin andrykonchin andrykonchin approved these changes

Assignees
No one assigned
Labels
in-ci The PR is being tested in CI. Do not push new commits. OCA Verified All contributors have signed the Oracle Contributor Agreement. shopify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thomasmarshall @andrykonchin @rwstauner @eregon