Logic to automatically find Graal if it's built as a sibling #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitr-ch
reviewed
Aug 7, 2017
| return nil unless File.exist?("#{sibling_compiler}/mxbuild/dists/graal-compiler.jar") | ||
| return nil if Dir.exist?("#{TRUFFLERUBY_DIR}/mx.imports/binary/truffle") | ||
| sibling_compiler | ||
| end |
There was a problem hiding this comment.
It could print a note that the compiler was found but needs compiling.
eregon
approved these changes
Aug 7, 2017
| @@ -146,10 +146,12 @@ $ export GRAALVM_BIN=.../graalvm-0.nn/bin/java | |||
| $ jt ruby --graal -e 'p Truffle.graal?' | |||
| ``` | |||
|
|
|||
| To run with Graal built from source, set `GRAAL_HOME`. | |||
| To run with Graal built from source, set `GRAAL_HOME`. Or it will be | |||
| automatically found if it is cloned into the same directory as `truffleruby`, it | |||
| graal_home = File.expand_path(graal_home, TRUFFLERUBY_DIR) | ||
| else | ||
| graal_home = auto_graal_home | ||
| end |
There was a problem hiding this comment.
This could be a one-liner above, before the if:
graal_home ||= find_auto_graal_home
dougxc
pushed a commit
that referenced
this pull request
Sep 28, 2018
…ster * commit '975373b6c3d4230e43f6a6b9047c0ca1f977844f': Increase read buffer size to increase throughput. Remove unused profile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.