More info on C extension compatibility problems #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitr-ch
approved these changes
Aug 28, 2017
eregon
reviewed
Sep 3, 2017
| and global variables may be macros. This causes problems where they are used in | ||
| a context which relies on a particular implementation, for example a global | ||
| variable assigned to an initial value which was a macro, like `Qnil`, which is | ||
| a macro that evaluates to a function call in TruffleRuby. |
There was a problem hiding this comment.
I think adding a specific example here (the global = Qnil; one) and a workaround would be very helpful here and clearer.
dougxc
pushed a commit
that referenced
this pull request
Nov 27, 2018
* commit 'b28603dbf30e5649279eb282693b7a12486c5056': Add tags for new failing specs Update to ruby/spec@cdd6ff7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.