Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set name for all vagrant images #39

Closed
gvenzl opened this issue May 25, 2018 · 2 comments
Closed

Set name for all vagrant images #39

gvenzl opened this issue May 25, 2018 · 2 comments
Assignees
@gvenzl
Labels
enhancement

Comments

@gvenzl
Copy link
Member

gvenzl commented May 25, 2018

Just like #31 we should have this for all images.
@gvenzl gvenzl self-assigned this May 25, 2018
@AmedeeBulle
Copy link
Member

FYI - K8s is already compliant

PaulNeumann added a commit to PaulNeumann/vagrant-projects that referenced this issue May 26, 2018
@PaulNeumann
Set name for all vagrant images (oracle#39)
3830cf9 
Change Vagrant box name from "default" to NAME for DockerEngine, LAMP, Oracle Database 11.2.0.2, Oracle Database 12.2.0.1, and Oracle Linux 7 with UEK5 preview boxes
This addresses the enhancement request in issue oracle#39. Kubernetes box not modified.

Signed-off-by: Paul Neumann <38871902+PaulNeumann@users.noreply.github.com>
@PaulNeumann PaulNeumann mentioned this issue May 28, 2018
Merged
scoter-oracle pushed a commit that referenced this issue May 30, 2018
Merge pull request #40 from PaulNeumann/39-set_vagrant_box_name
ccb4654 
Set name for all vagrant images (#39)
@gvenzl
Copy link
Member Author

gvenzl commented Jul 3, 2018

Merged

@gvenzl gvenzl closed this as completed Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gvenzl gvenzl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AmedeeBulle @gvenzl