Raise memory limit to 512M if below, closes #16 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing covers-validator on the default PHP 5.6 docker image with an application with ca. 5 900 tests, the default set memory limit of PHP with 128M[1] caused a limit violation and terminated the process. Fix is to conditionally raise the memory limit to 512M if it is below. That value *should* prevent first-use memory limit errors in such and similar configurations. If however the utility needs more memory (which might the case with more tests and/or a larger code base), this 512M then still may not be enough - just saying. Additionally error reporting is set to all kind of errors and the display of errors is switched on. This is generally useful as the files in the @Covers notations are then also parsed and deprecation or similar errors are displayed (w/o making the covers validation fail unless there is a failure with @Covers notations as well). Refs: - [1] http://php.net/manual/en/ini.core.php#ini.memory-limit - oradwell#16
|
Travis fails with PHP 5.3 as it is not available on Precise VM. Everything else looks good. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #17 just against 0.5. Done as Travis checks more PHP versions and I'm also bound to 0.5 use (yet).