OHRM5X-1757: Write Performance - API doc with OpenAPI #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RajithaKumara
approved these changes
Sep 30, 2022
| @@ -23,6 +23,8 @@ | |||
|
|
|||
| class ReviewEmployeeSupervisorSearchFilterParams extends FilterParams | |||
| { | |||
| public const ALLOWED_SORT_FIELDS = ['employee.empNumber']; | |||
There was a problem hiding this comment.
seems some validation rules missing in ReviewEmployeeSupervisorAPI::getValidationRuleForGetAll
return new ParamRuleCollection(
$this->getValidationDecorator()->notRequiredParamRule(
new ParamRule(
CommonParams::PARAMETER_EMP_NUMBER,
new Rule(Rules::POSITIVE)
),
),
$this->getValidationDecorator()->notRequiredParamRule(
new ParamRule(
self::FILTER_NAME_OR_ID,
new Rule(Rules::STRING_TYPE),
new Rule(
Rules::LENGTH,
[null, self::PARAM_RULE_FILTER_NAME_OR_ID_MAX_LENGTH]
),
)
),
// following line seems missing
...$this->getSortingAndPaginationParamsRules(ReviewEmployeeSupervisorSearchFilterParams::ALLOWED_SORT_FIELDS),
);
RajithaKumara
changed the title
RajithaKumara
pushed a commit
that referenced
this pull request
Sep 30, 2022
RajithaKumara
pushed a commit
to RajithaKumara/orangehrm
that referenced
this pull request
Oct 25, 2022
RajithaKumara
pushed a commit
that referenced
this pull request
Oct 25, 2022
Super-Chama
pushed a commit
to Super-Chama/orangehrm
that referenced
this pull request
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete API documentation for Performance Plugin