OHRM5X-1766: Improve doctrine connection for the application #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RajithaKumara
commented
Oct 25, 2022
| $isDevMode = false; | ||
| $proxyDir = Config::get(Config::DOCTRINE_PROXY_DIR); | ||
| $cache = null; | ||
| $useSimpleAnnotationReader = false; | ||
| $cache = new ArrayAdapter(); |
RajithaKumara
commented
Oct 25, 2022
| 'driver' => 'pdo_mysql', | ||
| 'url' => "mysql://$dbUser:$dbPass@$dbHost:$dbPort/$dbName", |
There was a problem hiding this comment.
Fix for:
Fatal error: Uncaught Doctrine\DBAL\Exception: Malformed parameter "url". in src/vendor/doctrine/dbal/src/DriverManager.php:306
and #1501 , #1504, #1344 issues
Quick fix:
Inside Doctrine.zip, there is a PHP file Doctrine.php.
Find current Doctrine.php inside <orangehrm>/src/lib/orm/ directory. And replace it with new file which is taken from the ZIP.
RajithaKumara
commented
Nov 3, 2022
| @@ -14,7 +14,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| database: [ 'mysql:5.5', 'mysql:5.6', 'mysql:5.7', 'mariadb:5.5', 'mariadb:10.0', 'mariadb:10.1', 'mariadb:10.2', 'mariadb:10.3', 'mariadb:10.4', 'mariadb:10.5', 'mariadb:10.6', 'mariadb:10.7', 'mariadb:10.8', 'mariadb:10.9' ] | |||
| database: [ 'mysql:5.5', 'mysql:5.6', 'mysql:5.7', 'mysql:8.0', 'mariadb:5.5', 'mariadb:10.0', 'mariadb:10.1', 'mariadb:10.2', 'mariadb:10.3', 'mariadb:10.4', 'mariadb:10.5', 'mariadb:10.6', 'mariadb:10.7', 'mariadb:10.8', 'mariadb:10.9' ] | |||
There was a problem hiding this comment.
MySQL 8.0 test action took longer than others (1.5 hours while others took 10 to 15 mins)
RajithaKumara
commented
Nov 7, 2022
| ->select('groups.id') | ||
| ->from('ohrm_i18n_group', 'groups') | ||
| ->andWhere('groups.name = :name') | ||
| ->select('ohrm_i18n_group.id') |
Super-Chama
pushed a commit
to Super-Chama/orangehrm
that referenced
this pull request
Dec 13, 2022
…rm#1506) * OHRM5X-1832: Bump MySQL max support to 8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.