Problem: need example of passing method arguments #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: extend START and START-OK commands with height argument that the server can echo back to client. See wap_client.c test case for this.
| @@ -177,7 +177,7 @@ prepare_get_command (client_t *self) | |||
| static void | |||
| signal_have_get_ok (client_t *self) | |||
| { | |||
| zsock_send (self->cmdpipe, "sip", "GET OK", 0, | |||
| zsock_send (self->cmdpipe, "sip", "GET OK", 0, | |||
| wap_proto_get_tx_data (self->message)); | |||
There was a problem hiding this comment.
How does this change relate to the "start" command whoss behaviour we're trying to change?
There was a problem hiding this comment.
Whitespace change, not significant.
On Sun, Jan 4, 2015 at 4:27 PM, oranjuice notifications@github.com wrote:
In src/wap_client.c
#4 (diff):@@ -177,7 +177,7 @@ prepare_get_command (client_t *self)
static void
signal_have_get_ok (client_t *self)
{
- zsock_send (self->cmdpipe, "sip", "GET OK", 0,
- zsock_send (self->cmdpipe, "sip", "GET OK", 0,
wap_proto_get_tx_data (self->message));How does this change relate to the "start" command whoss behaviour we're
trying to change?—
Reply to this email directly or view it on GitHub
https://github.com/oranjuice/monero-0mq/pull/4/files#r22439996.
There was a problem hiding this comment.
oh, I'm sorry. I mistook the next line as an addition :)
oranjuice
added a commit
that referenced
this pull request
Feb 16, 2015
Problem: need example of passing method arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: extend START and START-OK commands with height argument
that the server can echo back to client. See wap_client.c test case
for this.