chore: issue templates #716
Conversation
Signed-off-by: dextrot <131444479+dextrot@users.noreply.github.com>
dextrot
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
Wwwsylvia
as code owners
|
added the issue templates here @FeynmanZhou @shizhMSFT |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
=======================================
Coverage 75.92% 75.92%
=======================================
Files 59 59
Lines 5873 5873
=======================================
Hits 4459 4459
Misses 1037 1037
Partials 377 377 ☔ View full report in Codecov by Sentry. |
Signed-off-by: SKM <131444479+dextrot@users.noreply.github.com>
There was a problem hiding this comment.
@dextrot Issue templates for oras-go should not be directly copied from the oras repo since the SDK is very different from a CLI.
Consider adapting issue templates from notation-go, which is also a golang library.
| required: true | ||
| attributes: | ||
| label: What happened in your environment? | ||
| description: "Please also attach logs here using `--debug` flag." |
There was a problem hiding this comment.
Since oras-go is a library, there is no --debug flag.
There was a problem hiding this comment.
@shizhMSFT can we put the description like : description: "Please also attach logs here ." ?
There was a problem hiding this comment.
can we put the description like : description: "Please also attach logs here ." ?
This sounds good to me.
| label: What is the version of your ORAS CLI? | ||
| description: "You can use the command `oras version` to get it." |
There was a problem hiding this comment.
Again, it is oras-go library, not a CLI. There is no oras version command for it.
There was a problem hiding this comment.
This also applies to feature-request.yaml.
Co-authored-by: Feynman Zhou <feynmanzhou@microsoft.com> Signed-off-by: SKM <131444479+dextrot@users.noreply.github.com>
Co-authored-by: Feynman Zhou <feynmanzhou@microsoft.com> Signed-off-by: SKM <131444479+dextrot@users.noreply.github.com>
Co-authored-by: Feynman Zhou <feynmanzhou@microsoft.com> Signed-off-by: SKM <131444479+dextrot@users.noreply.github.com>
There was a problem hiding this comment.
Thanks @dextrot . Please do not replicate the ORAS issue template here as they have different functionalities. PTAL at my comments above
Signed-off-by: SKM <131444479+dextrot@users.noreply.github.com>
Signed-off-by: SKM <131444479+dextrot@users.noreply.github.com>
Signed-off-by: SKM <131444479+dextrot@users.noreply.github.com>
|
@dextrot Thanks for the contribution! Could you address the remaining comments and rebase? |
This PR fixes #641
Bug report,feature requestand the config file for the templates.