Registry Client #82
Merged
Registry Client #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
shizhMSFT
requested review from
deitch,
jdolitsky,
sajayantony,
SteveLasker and
Wwwsylvia
|
@shizhMSFT, is this ready for user (me) validation? I can provide a PR review based on the end results, if you think it's ready. |
sajayantony
reviewed
Dec 6, 2021
sajayantony
reviewed
Dec 6, 2021
@SteveLasker It is ready to use for registries without any authentication like |
mnltejaswini
reviewed
Dec 7, 2021
mnltejaswini
reviewed
Dec 7, 2021
mnltejaswini
reviewed
Dec 7, 2021
mnltejaswini
reviewed
Dec 7, 2021
mnltejaswini
reviewed
Dec 7, 2021
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
sajayantony
approved these changes
Dec 8, 2021
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
|
Should merge this in and address the remaining as additive smaller PRs? |
Wwwsylvia
reviewed
Dec 16, 2021
Wwwsylvia
reviewed
Dec 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registry client implementation for #57.
Authentication implementation will be in another PR.