Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry Auth Client #85

Merged
merged 2 commits into from
Dec 24, 2021
Merged

Conversation

shizhMSFT
Copy link
Contributor

Registry authentication implementation for #57.

Change logs:

  • Implementation authentication for the registry client.
  • Resolves Registry Target #57.
  • Addresses comments in Registry Client #82.
  • Bump up golang version from v1.16 to v1.17 due to the use of new built-in library functions.

Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt like I was reading through my reimplementation of the OCI registry client in Ruby years ago, but much better done.

I do wish we could have a shared implementation of this to everyone. Now docker has one in moby, and google in ggcr, and container has one, and...

As long as this works, it is good. Maybe at one point we all can join forces?

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
Copy link
Contributor Author

As long as this works, it is good. Maybe at one point we all can join forces?

Yes, we will 😄 and oras-go has lots of advantages. It is more extensible and has fewer dependencies.

Most importantly, it will be integrated into many security products.

@shizhMSFT shizhMSFT merged commit 4a2d507 into oras-project:main Dec 24, 2021
ORAS CLI/Go-lib Project Board automation moved this from Backlog to Done Dec 24, 2021
@shizhMSFT shizhMSFT deleted the registry_auth branch December 24, 2021 08:49
@SteveLasker
Copy link
Contributor

great work @shizhMSFT, @deitch
High profile area always have multiple implementations. The refactoring @deitch started with @shizhMSFT have been simply marvelous!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Registry Target
3 participants