doc (spec): add error message guideline #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
|
Are we going to link this file from https://oras.land/docs/community/developer_guide |
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
=======================================
Coverage 81.92% 81.92%
=======================================
Files 83 83
Lines 3995 3995
=======================================
Hits 3273 3273
Misses 499 499
Partials 223 223 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Yes. We could add this doc link to that guide after it is merged. |
FeynmanZhou
requested review from
sajayantony,
shizhMSFT,
SteveLasker,
qweeah and
TerryHowe
as code owners
|
The examples and patterns are really helpful @FeynmanZhou. Thanks for putting this together. |
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
shizhMSFT
reviewed
Jan 3, 2024
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
qweeah
reviewed
Jan 5, 2024
qweeah
reviewed
Jan 5, 2024
qweeah
reviewed
Jan 5, 2024
qweeah
reviewed
Jan 5, 2024
qweeah
reviewed
Jan 5, 2024
qweeah
reviewed
Jan 5, 2024
qweeah
reviewed
Jan 5, 2024
qweeah
reviewed
Jan 5, 2024
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
qweeah
reviewed
Jan 10, 2024
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
|
@oras-project/oras-cli Are we good to merge this PR now? |
FeynmanZhou
added a commit
to FeynmanZhou/oras
that referenced
this pull request
May 11, 2024
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> Co-authored-by: Billy Zha <jinzha1@microsoft.com> Co-authored-by: Billy Zha <qweeah@gmail.com> Co-authored-by: Terry Howe <tlhowe@amazon.com> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add CLI error handling guide
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1158
Please check the following list: