Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update module file for 1.13" #134

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Conversation

jdolitsky
Copy link
Contributor

Reverts #132

@jdolitsky
Copy link
Contributor Author

some error on CI:

# github.com/docker/cli/cli/config                                                                                             
/go/pkg/mod/github.com/docker/cli@v0.0.0-20191007193719-3e07fa728a30/cli/config/config.go:30:19: undefined: os.UserHomeDir     
/go/pkg/mod/github.com/docker/cli@v0.0.0-20191007193719-3e07fa728a30/cli/config/config.go:111:18: undefined: os.UserHomeDir    
# github.com/docker/distribution/registry                                                                                      
/go/pkg/mod/github.com/docker/distribution@v2.7.1+incompatible/registry/registry.go:157:10: undefined: letsencrypt.Manager     
FAIL    github.com/deislabs/oras/pkg/auth/docker [build failed] 

reverting #132 until we can fix

cc @jpreese

@jdolitsky jdolitsky merged commit eda7eb2 into master Oct 17, 2019
@jpreese
Copy link
Contributor

jpreese commented Oct 17, 2019

@jdolitsky

This is most likely due to the yml in the .codefresh/ dir that references golang-1.11, and the Dockerfile. The module resolution algorithm changes quite a bit from 1.11 to 1.12, and some more from 1.12 to 1.13.

Is there a way I can update the golang version that the pr/release use and test it locally? Definitely value in getting those wired up, unless I've missed it.

@jdolitsky jdolitsky deleted the revert-132-oras-modules branch November 12, 2020 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants