Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print digest and media type when content is skipped using sync.Map #510

Merged
merged 3 commits into from
Aug 19, 2022
Merged

feat: print digest and media type when content is skipped using sync.Map #510

merged 3 commits into from
Aug 19, 2022

Conversation

wangxiaoxuan273
Copy link
Contributor

Print digest and media type when content is skipped, and use sync.Map to ensure skipped content is printed only once.

Part of issue #415
Signed-off-by: wangxiaoxuan273 wangxiaoxuan119@gmail.com

…ap to ensure printing only once

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
cmd/oras/pull.go Outdated Show resolved Hide resolved
cmd/oras/pull.go Outdated Show resolved Hide resolved
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #510 (5562ddb) into main (27e9834) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage   72.68%   72.68%           
=======================================
  Files           9        9           
  Lines         388      388           
=======================================
  Hits          282      282           
  Misses         85       85           
  Partials       21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/oras/pull.go Outdated Show resolved Hide resolved
cmd/oras/pull.go Outdated Show resolved Hide resolved
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 8bd2dc2 into oras-project:main Aug 19, 2022
@wangxiaoxuan273 wangxiaoxuan273 deleted the sync-map branch August 19, 2022 07:56
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
…Map (oras-project#510)

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants