test: add e2e specs for oras pull
#693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #693 +/- ##
=======================================
Coverage 72.23% 72.23%
=======================================
Files 14 14
Lines 515 515
=======================================
Hits 372 372
Misses 114 114
Partials 29 29 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
reviewed
Dec 14, 2022
test/e2e/suite/command/pull.go
Outdated
| } | ||
| ORAS("pull", Reference(Host, repo, tag), "-v", "--config", files[0], "-o", pullRoot). | ||
| MatchStatus([]match.StateKey{ | ||
| {Digest: "fd6ed2f36b54", Name: "application/vnd.oci.image.manifest.v1+json"}, |
There was a problem hiding this comment.
Should it use ocispec.MediaTypeImageManifest in terms of consistency? see line 104-105
test/e2e/suite/command/pull.go
Outdated
| } | ||
| ORAS("pull", Reference(Host, repo, tag), "-v", "--config", fmt.Sprintf("%s:%s", files[0], "???"), "-o", pullRoot). | ||
| MatchStatus([]match.StateKey{ | ||
| {Digest: "fd6ed2f36b54", Name: "application/vnd.oci.image.manifest.v1+json"}, |
There was a problem hiding this comment.
Updated also the config type
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
Resolves: oras-project#567 Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #567