-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move ParseRepoPath to internal package #817
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am not sure why this doesn't trigger codcov auto comment. The coverage rate increases ~7% in https://app.codecov.io/gh/oras-project/oras/pulls. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #817 +/- ##
==========================================
+ Coverage 56.03% 63.50% +7.47%
==========================================
Files 23 21 -2
Lines 953 844 -109
==========================================
+ Hits 534 536 +2
+ Misses 376 265 -111
Partials 43 43
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Putting it in
cmd/oras/internal
will trigger code coverage scan on command declaration code, which effects our code coverage.