Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links between deeply nested subfolders fails #35

Closed
Mara-Li opened this issue Jan 14, 2022 · 4 comments
Closed

Links between deeply nested subfolders fails #35

Mara-Li opened this issue Jan 14, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Mara-Li
Copy link

Mara-Li commented Jan 14, 2022

Hello. On my project, wikilinks doesn't seems to work.

My folder tree is :

docs/
├─ assets/
│  ├─ img/
│  │  ├─ img_char1.png
├─ Roleplay/
│  ├─ characters/
│  │  ├─ char1.md
│  ├─ references/
│  │  ├─ ref char1.md
  • All links pointing to img doesn't work
  • All link from char1 to ref char1 doesn't work.

Links is in a short path, as : [[filename]]

I have 404 error and the path pointed by links are :
image

After some try, it seems that after the 3rd folder, the links generations are broken.

image

@orbikm orbikm self-assigned this Jan 23, 2022
@orbikm orbikm added the bug Something isn't working label Jan 23, 2022
@orbikm
Copy link
Owner

orbikm commented Jan 23, 2022

I have reproduced your issue. I'm going to start investigating what is going on. Thank you for the report!

@Mara-Li
Copy link
Author

Mara-Li commented Jan 24, 2022

Hello !
I'm happy to help you :D

I think it's possible to use resolve from pathlib or maybe something around glob all file ?

orbikm added a commit that referenced this issue Jan 24, 2022
* Resolves Github Issue #35

* Fixes path searching on Windows machines
orbikm added a commit that referenced this issue Jan 24, 2022
* Resolves Github Issue #35

* Fixes path searching on Windows machines
@orbikm orbikm changed the title wikilinks doesn't work Links between deeply nested subfolders fails Jan 24, 2022
@orbikm
Copy link
Owner

orbikm commented Jan 24, 2022

Ok, this should be fixed now. Please pull down release 0.1.14 and let me know if this addresses it on your end. Feel free to re-open if the issue remains unresolved.

Once again, thanks for reporting the issue and using the plugin!

@orbikm orbikm closed this as completed Jan 24, 2022
@Mara-Li
Copy link
Author

Mara-Li commented Jan 26, 2022

It doesn't seems to work, on my side at last (windows 11) :
image
image
image

image

Image are localized in assets/img who is in directly under docs (as docs/assets/img) and Mnémosyne folder is located in docs/Roleplay/Personnages/Mnémosyne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants