Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and add image of ST_CompactnessRatio #138

Merged
merged 6 commits into from Jan 29, 2014
Merged

Update and add image of ST_CompactnessRatio #138

merged 6 commits into from Jan 29, 2014

Conversation

mlecoeuvre
Copy link
Contributor

See #105.

agouge
agouge reviewed Jan 23, 2014
View reviewed changes
docs/dev/ST_CompactnessRatio.md
@@ -2,7 +2,7 @@
layout: docs
title: ST_CompactnessRatio
category: h2spatial-ext/properties
description:
description: Returns the ratio of this computed perimeter to the given `polygon`'s perimeter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style guide 1.ii

agouge
agouge reviewed Jan 23, 2014
View reviewed changes
docs/dev/ST_CompactnessRatio.md
@@ -2,7 +2,7 @@
layout: docs
title: ST_CompactnessRatio
category: h2spatial-ext/properties
description:
description: Returns the ratio of this computed perimeter to the given <CODE>POLYGON</CODE>'s perimeter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@agouge
Copy link
Contributor

agouge commented Jan 23, 2014

You still need to fix your line breaks

@agouge agouge mentioned this pull request Jan 23, 2014
Closed
gpetit
gpetit reviewed Jan 24, 2014
View reviewed changes
docs/dev/ST_CompactnessRatio.md
@@ -11,14 +11,52 @@ permalink: /docs/dev/ST_CompactnessRatio/
### Signature

{% highlight mysql %}
double ST_CompactnessRatio(POLYGON poly)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.ii
geom rather than poly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actualy poly is better, since this function accepts only POLYGONs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok :-)

agouge
agouge reviewed Jan 27, 2014
View reviewed changes
docs/dev/ST_CompactnessRatio.md
-- Answer: 0.9983912919723259
-- Note : That a buffer is not a circle. It's an
-- approximation, ST_Buffer create 32 segments to arc of a
-- cercle. That's why the compactness ratio is not equal to 1.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling

@agouge agouge merged commit 5cd726e into orbisgis:gh-pages Jan 29, 2014
@mlecoeuvre mlecoeuvre deleted the st_compactnessratio branch January 29, 2014 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
h2gis.org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mlecoeuvre @agouge @nicolas-f @gpetit