Add missing property functions #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public static Double computeCompacity(Geometry geom) { | ||
| if (geom != null) { | ||
| if (GeometryTypeUtil.isPolygon(geom)) { |
There was a problem hiding this comment.
You could have used SC_Polygon.isPolygon()
Note 1: PostGIS does not allow ST_3DLength to take a Polygon as a parameter. For this purpose, a PostGIS user must use ST_Perimeter, which was not implemented in GDMS. Note 2: PostGIS also allows MutliLineStrings (for ST_3DLength) and MultiPolygons (for ST_Perimeter), while GDMS only allowed for LineStrings and Polygons.
|
@ebocher As for ST_CircleCompacity, we could certainly call this ST_CircleIndex. But according to your link (http://www.spatialanalysisonline.com/HTML/?shape.htm), this doesn't seem to be a standardized index. Instead of dividing the circle circumference by the polygon perimeter, the compactness ratio (C) takes the square root of the circle area divided by the polygon area. This is similar, but different. So now the question is which formula we keep (or both), and what name we use (ST_CompactnessRatio for the root of the ratio of areas?). |
Note that the definition given in http://www.spatialanalysisonline.com/HTML/?shape.htm is equivalent to the previous definition (in ST_CircleCompacity).
agouge
added a commit
to agouge/H2GIS
that referenced
this pull request
Nov 21, 2013
Before, ST_3DLength was returning 0 for a 2D geometry, which didn't make any sense. Now it returns the same value as ST_Length for 2D geometries. Unit tests added. Fixes orbisgis#29.
Before, ST_3DLength was returning 0 for a 2D geometry, which didn't make any sense. Now it returns the same value as ST_Length for 2D geometries. Unit tests added. Fixes orbisgis#33.
|
OK ready to merge. |
nicolas-f
added a commit
that referenced
this pull request
Nov 21, 2013
Add missing property functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we add
Note: PostGIS says ST_CoordDim is SFS, but it doesn't seem to be.