Add triangle analysis function #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
||
| /** | ||
| * This function is used to computed the aspect of a triangle Aspect represents | ||
| * the main slope direction angle compared to the north direction. |
There was a problem hiding this comment.
"to compute" ...
missing '.' before 'Aspect'
Please see all my javadoc comments in orbisgis/orbisgis#556.
| import org.jdelaunay.delaunay.geometries.DTriangle; | ||
|
|
||
| /** | ||
| * This function is used to compute the aspect of a triangle aspect represents |
There was a problem hiding this comment.
This is a run-on sentence. You need a '.' after triangle.
| + "(ST_GeomFromText('POLYGON ((0 0 0, 4 0 0, 2 3 9, 0 0 0))'));"); | ||
| ResultSet rs = st.executeQuery("SELECT ST_TriangleDirection(the_geom) FROM input_table;"); | ||
| rs.next(); | ||
| assertTrue(((Geometry)rs.getObject(1)).equals(WKT_READER.read("LINESTRING(2 1 3, 2 0 0)"))); |
There was a problem hiding this comment.
just a comment, nothing to change. You can do:
assertEquals("LINESTRING(2 1 3, 2 0 0)", rs.getString(1))
agouge
added a commit
that referenced
this pull request
Dec 16, 2013
Add triangle analysis functions This PR adds 3 new functions for triangle. ```mysql ST_TriangleSlope(GEOMETRY); ``` Compute the slope of a triangle in degrees ```mysql ST_TriangleAspect(GEOMETRY); ``` Compute the aspect of a triangle Aspect represents the main slope direction angle compared to the north direction. ```mysql ST_TriangleDirection(GEOMETRY); ``` Compute the main slope direction on a triangle represented by a linesegment See #46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 3 new functions for triangle.
Compute the slope of a triangle in degrees
Compute the aspect of a triangle Aspect represents the main slope direction angle compared to the north direction.
Compute the main slope direction on a triangle represented by a linesegment
See #46.